-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass arguments to installOnline function #5
base: master
Are you sure you want to change the base?
Conversation
@Neilpang ping? |
btw, @honzahommer |
@msva Thanks, example updated. |
and, btw, adding possiblity to not install cron/profile based on env variables would be great too. I think it will be even enough to just: @@ -5715,9 +5715,9 @@ install() {
LE_WORKING_DIR="$DEFAULT_INSTALL_HOME"
fi
- _nocron="$1"
+ _nocron="${NO_CRON:-$1}"
_c_home="$2"
- _noprofile="$3"
+ _noprofile="${NO_PROFILE:-$3}"
if ! _initpath; then
_err "Install failed."
return 1 as minimum. |
@msva It's good idea, thanks. Actually there is possibility to do this: wget ... | sh -s nocron noprofile
wget ... | sh -s "" noprofile
wget ... | sh -s nocron "" |
I actually meant that case: export NO_CRON=1 NO_PROFILE=1
$fetcher_cmd ... | sh // actually, my real case is having them in my shell-rc-file, so that acme.sh will never touch either:
irrelevant if I forgot to pass parameters on that exact machine :) |
|
Yeah, that PR would be right place to discuss that. Thanks. |
This PR allows to pass arguments as referenced in in issue #2, related PR acmesh-official/acme.sh#2274.