If metadata write mode is "merge", apply the "merge" rule for title o…

…nly on the language level (resolves #19)
acdh-oeaw · Nov 25, 2021 · 9485327 · 9485327
1 parent d3bb96f
commit 9485327
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 0 deletions.
diff --git a/src/acdhOeaw/arche/doorkeeper/Doorkeeper.php b/src/acdhOeaw/arche/doorkeeper/Doorkeeper.php
@@ -45,6 +45,7 @@
 use acdhOeaw\UriNormalizer;
 use acdhOeaw\epicHandle\HandleService;
 use acdhOeaw\arche\core\Transaction;
+use acdhOeaw\arche\core\Metadata;
 use acdhOeaw\arche\core\Resource as Res;
 use acdhOeaw\arche\core\RestController as RC;
 use acdhOeaw\arche\lib\schema\Ontology;
@@ -620,6 +621,26 @@ static private function checkTitleProp(Resource $meta): void {
             }
             $langs[$lang] = (string) $i;
         }
+
+        // preserve old titles when needed
+        $mode = RC::getRequestParameter('metadataWriteMode');
+        if ($mode === Metadata::SAVE_MERGE) {
+            $query = RC::$pdo->prepare("
+                SELECT value, lang 
+                FROM metadata 
+                WHERE property = ? AND id = ?
+            ");
+            $id    = preg_replace('|^.*/|', '', $meta->getUri());
+            $query->execute([$titleProp, $id]);
+            while ($i     = $query->fetchObject()) {
+                if (!isset($langs[$i->lang])) {
+                    $titles[] = '';
+                    $meta->addLiteral($titleProp, $i->value, $i->lang);
+                }
+            }
+        }
+
+        // if everything's fine, just return
         if (count($titles) > 0) {
             return;
         }

diff --git a/tests/ResourceTest.php b/tests/ResourceTest.php
@@ -469,6 +469,38 @@ public function testTitleAuto(): void {
         $this->assertContains('bar', $titles);
     }
 
+    public function testTitlePreserveOtherLang(): void {
+        $titleProp = self::$config->schema->label;
+        self::$repo->begin();
+
+        $meta = self::createMetadata([$titleProp => new Literal('foo', 'en')]);
+        $res  = self::$repo->createResource($meta);
+        $meta->delete($titleProp);
+        $meta->addLiteral($titleProp, 'bar', 'de');
+
+        $res->setMetadata($meta);
+        $res->updateMetadata(RepoResource::UPDATE_MERGE);
+        $tmp    = $res->getGraph()->allLiterals($titleProp);
+        $titles = [];
+        foreach ($tmp as $i) {
+            $titles[$i->getLang()] = (string) $i;
+        }
+        $this->assertEquals(2, count($titles));
+        $this->assertArrayHasKey('en', $titles);
+        $this->assertArrayHasKey('de', $titles);
+        $this->assertEquals('foo', $titles['en']);
+        $this->assertEquals('bar', $titles['de']);
+
+        $res->setMetadata($meta);
+        $res->updateMetadata(RepoResource::UPDATE_OVERWRITE);
+        $titles = $res->getGraph()->allLiterals($titleProp);
+        $this->assertEquals(1, count($titles));
+        $this->assertEquals('bar', (string) $titles[0]);
+        $this->assertEquals('de', $titles[0]->getLang());
+
+        self::$repo->rollback();
+    }
+
     /**
      * 
      * @depends testTitleAuto