feat(generic): refactor GenericRDFBaseRenderer and add CIDOC renderers #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GenericRDFBaseRenderer now uses graphs instead of working with triples. Additionaly it is possible to override the serialization format by setting the renderers `rdflib_format` attribute. If this is not set, the serialization uses the `format` attribute from the renderer as serialization format.
This serializer should provide a basis for CIDOC serializers as well as a fallback for models that have no CIDOC serializer configured.
Those serializers are based on the GenericModelCidocSerializer and add addional attributes like birth and death information and geocoordinates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GenericRDFBaseRenderer now uses graphs instead of working with
triples. Additionaly it is possible to override the serialization format
by setting the renderers
rdflib_formatattribute. If this is not set,the serialization uses the
formatattribute from the renderer asserialization format.