Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update concerto dependencies #605

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

ekarademir
Copy link
Contributor

@ekarademir ekarademir commented May 24, 2024

Updates concerto dependencies to the latest versions

Changes

  • Mapped axios dependency to jest compatible transpiled file where jest is used for testing

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Ertugrul Karademir <[email protected]>
@ekarademir ekarademir marked this pull request as draft May 24, 2024 07:46
@ekarademir
Copy link
Contributor Author

Current state:
One of the deep dependencies is relying on Axios, which is using ECMA module. Jest is refusing to transform that to CJS module. I am still playing with Jest and Babel configurations to make the transformation happen so that test can run.

Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
@ekarademir ekarademir marked this pull request as ready for review June 14, 2024 12:13
Copy link
Contributor

Pull Request Test Coverage Report for Build 9515869753

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 69.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/markdown-template/lib/ModelVisitor.js 0 1 0.0%
packages/markdown-template/lib/templatemarkutil.js 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
packages/markdown-template/lib/errorutil.js 1 15.38%
packages/markdown-pdf/src/pdfmakeutil.js 1 72.5%
packages/markdown-template/lib/ModelVisitor.js 20 0.0%
Totals Coverage Status
Change from base Build 9206016892: -0.3%
Covered Lines: 2776
Relevant Lines: 3804

💛 - Coveralls

@ekarademir
Copy link
Contributor Author

Fixed the testing issue.

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9515869753

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 69.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/markdown-template/lib/ModelVisitor.js 0 1 0.0%
packages/markdown-template/lib/templatemarkutil.js 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
packages/markdown-template/lib/errorutil.js 1 15.38%
packages/markdown-pdf/src/pdfmakeutil.js 1 72.5%
packages/markdown-template/lib/ModelVisitor.js 20 0.0%
Totals Coverage Status
Change from base Build 9206016892: -0.3%
Covered Lines: 2776
Relevant Lines: 3804

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9515914026

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 69.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/markdown-template/lib/ModelVisitor.js 0 1 0.0%
packages/markdown-template/lib/templatemarkutil.js 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
packages/markdown-template/lib/errorutil.js 1 15.38%
packages/markdown-pdf/src/pdfmakeutil.js 1 72.5%
packages/markdown-template/lib/ModelVisitor.js 20 0.0%
Totals Coverage Status
Change from base Build 9206016892: -0.3%
Covered Lines: 2776
Relevant Lines: 3804

💛 - Coveralls

Signed-off-by: Ertugrul Karademir <[email protected]>
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9516187291

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 69.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/markdown-template/lib/ModelVisitor.js 0 1 0.0%
packages/markdown-template/lib/templatemarkutil.js 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
packages/markdown-template/lib/errorutil.js 1 15.38%
packages/markdown-pdf/src/pdfmakeutil.js 1 72.5%
packages/markdown-template/lib/ModelVisitor.js 20 0.0%
Totals Coverage Status
Change from base Build 9206016892: -0.3%
Covered Lines: 2776
Relevant Lines: 3804

💛 - Coveralls

Signed-off-by: Ertugrul Karademir <[email protected]>
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9516646038

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 69.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/markdown-template/lib/ModelVisitor.js 0 1 0.0%
packages/markdown-template/lib/templatemarkutil.js 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
packages/markdown-template/lib/errorutil.js 1 15.38%
packages/markdown-pdf/src/pdfmakeutil.js 1 72.5%
packages/markdown-template/lib/ModelVisitor.js 20 0.0%
Totals Coverage Status
Change from base Build 9206016892: -0.3%
Covered Lines: 2776
Relevant Lines: 3804

💛 - Coveralls

@ekarademir ekarademir merged commit b21a6f3 into main Jun 14, 2024
17 checks passed
@ekarademir ekarademir deleted the ertugrul/update-concerto-dependencies branch June 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants