New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we mark playlist/items as dirty when item is removed #1144

Merged

chvp merged 1 commit into main from fix/playlist-delete-items

May 21, 2024

Member

robbevp commented May 20, 2024

This PR fixes two (related) issues with the playlist form. When an item was removed, we didn't set isDirty and itemsDirty. This meant that:

Updates to the playlist in the store would still change form's content
An update where only items where removed would not be correctly sent to the api


          Make sure we mark playlist/items as dirty when item is removed

0acd105

robbevp added the bug label

robbevp requested a review from chvp

May 20, 2024 12:36

robbevp self-assigned this

chvp approved these changes

View reviewed changes

chvp merged commit 7003e63 into main

2 checks passed

chvp deleted the fix/playlist-delete-items branch

May 21, 2024 09:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug