Refactor sending audio in TracksController by switching back to Rack::Files #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, this was the previous implementation for simple file serving, but this was refactored out in #216. |
chvp
force-pushed
the
chore/refactor-audio-with-file
branch
4 times, most recently
from
8194c11 to
c385ff2
Compare
…:Files Since we never do live transcoding anymore, we can simplify the way we send audio data to clients a lot. We can remove the usage of `ActionController::Live` and don't have to do any manual copying to and from streams, all by just switching back to Rack::Files.
chvp
force-pushed
the
chore/refactor-audio-with-file
branch
from
c385ff2 to
9c5d942
Compare
robbevp
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we never do live transcoding anymore, we can simplify the way we send
audio data to clients a lot. We can remove the usage of
ActionController::Liveand don't have to do any manual copying to and from streams, all by just
switching back to Rack::Files.
Fixes #649.