Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rails 8 #680

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Update to rails 8 #680

merged 1 commit into from
Nov 12, 2024

Conversation

chvp
Copy link
Member

@chvp chvp commented Nov 9, 2024

No description provided.

@chvp chvp added the chore Repository or build maintenance label Nov 9, 2024
@chvp chvp requested a review from robbevp November 9, 2024 12:02
@chvp chvp marked this pull request as draft November 9, 2024 12:13
@chvp
Copy link
Member Author

chvp commented Nov 9, 2024

active_model_serializers doesn't seem to be compatible with Rails 8. It's not maintained at all, so I'll switch away from it. (But I'll do that in a separate MR.)

@chvp chvp force-pushed the chore/chvp-rails-8 branch from 086419a to e8b78b0 Compare November 9, 2024 14:43
@chvp chvp changed the base branch from main to chore/remove-ams November 9, 2024 14:43
@chvp chvp force-pushed the chore/remove-ams branch from e44b95e to 5c2fcb9 Compare November 9, 2024 15:04
@chvp chvp force-pushed the chore/chvp-rails-8 branch from e8b78b0 to 27285e6 Compare November 9, 2024 15:07
@chvp
Copy link
Member Author

chvp commented Nov 9, 2024

Based on #681, that should be looked at and merged first.

@chvp chvp marked this pull request as ready for review November 9, 2024 15:16
@chvp chvp force-pushed the chore/remove-ams branch 3 times, most recently from be4b10f to 41f61be Compare November 11, 2024 14:28
@chvp chvp force-pushed the chore/chvp-rails-8 branch from 27285e6 to 7675233 Compare November 11, 2024 14:34
Base automatically changed from chore/remove-ams to main November 11, 2024 14:49
robbevp
robbevp requested changes Nov 11, 2024
View reviewed changes
config/puma.rb Outdated Show resolved Hide resolved
@chvp chvp force-pushed the chore/chvp-rails-8 branch from 7675233 to 03c39f5 Compare November 11, 2024 15:26
@chvp chvp requested a review from robbevp November 11, 2024 15:27
@robbevp robbevp merged commit 520ff39 into main Nov 12, 2024
5 checks passed
@robbevp robbevp deleted the chore/chvp-rails-8 branch November 12, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbevp robbevp robbevp approved these changes

Assignees
No one assigned
Labels
chore Repository or build maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chvp @robbevp