Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueue codec_conversion transcodes on slower queue #657

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

chvp
Copy link
Member

@chvp chvp commented Oct 10, 2024

Fixes #653.

@chvp chvp added the chore Repository or build maintenance label Oct 10, 2024
@chvp chvp requested a review from robbevp October 10, 2024 19:18
Copy link
Member

@robbevp robbevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even move this to our slowest queue. If we see these queues as a contrqct wehere the task should be picked up in this time. This will probably not happen when we enqueue these tasks in bulk.

@chvp chvp force-pushed the chore/enqueue-cc-transcodes-on-slower-queue branch from 91dcffe to 88da975 Compare October 10, 2024 19:29
@chvp
Copy link
Member Author

chvp commented Oct 10, 2024

In practice there is little difference; both queues are not used by any other jobs. But agree that the semantics of whenever are clearer for this case.

@chvp chvp requested a review from robbevp October 10, 2024 19:29
@robbevp robbevp enabled auto-merge (squash) October 10, 2024 19:31
@robbevp robbevp merged commit 3b0f6d5 into main Oct 10, 2024
4 checks passed
@robbevp robbevp deleted the chore/enqueue-cc-transcodes-on-slower-queue branch October 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository or build maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak QueueTranscodedItemsForCodecConversionJob so that CreateTranscodeJobs are queued on a low-priority queue
2 participants