Make sure we wait for ffmpeg to finish (#650)

accentor · Oct 9, 2024 · 7e7f8d2 · 7e7f8d2
1 parent 79765f3
commit 7e7f8d2
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/models/audio_file.rb b/app/models/audio_file.rb
@@ -46,7 +46,10 @@ def convert(codec_conversion, out_file_name)
       '-map', 'a',
       out_file_name,
       err: [Rails.configuration.ffmpeg_log_location, 'a']
-    )
+    ) do |_stdin, _stdout, _wait_thr|
+      # We call `Open3.popen2` with an empty block, so the process finishes before we return
+      # This returns `Process::Status`
+    end
   end
 
   def full_path