Bump rubocop-rails from 2.24.1 to 2.25.0 in the rubocop group (#570)

* Bump rubocop-rails from 2.24.1 to 2.25.0 in the rubocop group Bumps the rubocop group with 1 update: [rubocop-rails](https://github.com/rubocop/rubocop-rails). Updates `rubocop-rails` from 2.24.1 to 2.25.0 - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.24.1...v2.25.0) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rubocop ... Signed-off-by: dependabot[bot] <[email protected]> * Update gemset.nix * Autocorrect * Also change played_after --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Charlotte Van Petegem <[email protected]>
accentor · May 18, 2024 · 472d392 · 472d392
1 parent 939dc8e
commit 472d392
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 27 deletions.
diff --git a/Gemfile b/Gemfile
@@ -51,6 +51,6 @@ group :development do
   gem 'annotate', '~> 3.2' # Remove workaround in lib/tasks/annotate.rb when https://github.com/ctran/annotate_models/issues/696 is fixed
   gem 'rubocop-factory_bot', '~> 2.25'
   gem 'rubocop-minitest', '~> 0.35.0'
-  gem 'rubocop-rails', '~> 2.24'
+  gem 'rubocop-rails', '~> 2.25'
   gem 'ruby-lsp', '~> 0.16.6'
 end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -138,7 +138,7 @@ GEM
     irb (1.13.1)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.7.1)
+    json (2.7.2)
     jsonapi-renderer (0.2.2)
     language_server-protocol (3.17.0.3)
     loofah (2.22.0)
@@ -172,7 +172,7 @@ GEM
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     parallel (1.24.0)
-    parser (3.3.0.5)
+    parser (3.3.1.0)
       ast (~> 2.4.1)
       racc
     pg (1.5.6)
@@ -228,12 +228,12 @@ GEM
     rake (13.2.1)
     rdoc (6.6.3.1)
       psych (>= 4.0.0)
-    regexp_parser (2.9.0)
+    regexp_parser (2.9.2)
     reline (0.5.7)
       io-console (~> 0.5)
     rexml (3.2.8)
       strscan (>= 3.0.9)
-    rubocop (1.62.1)
+    rubocop (1.63.5)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
@@ -244,14 +244,14 @@ GEM
       rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.2)
-      parser (>= 3.3.0.4)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
     rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
     rubocop-minitest (0.35.0)
       rubocop (>= 1.61, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rails (2.24.1)
+    rubocop-rails (2.25.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
@@ -309,7 +309,7 @@ DEPENDENCIES
   rails (~> 7.1)
   rubocop-factory_bot (~> 2.25)
   rubocop-minitest (~> 0.35.0)
-  rubocop-rails (~> 2.24)
+  rubocop-rails (~> 2.25)
   ruby-lsp (~> 0.16.6)
   simplecov (~> 0.21)
   tzinfo-data

diff --git a/app/models/play.rb b/app/models/play.rb
@@ -15,6 +15,6 @@ class Play < ApplicationRecord
 
   scope :by_album, ->(album) { where(track_id: Track.by_album(album)) }
   scope :by_artist, ->(artist) { where(track_id: Track.by_artist(artist)) }
-  scope :played_before, ->(date) { where('played_at < ?', date) }
-  scope :played_after, ->(date) { where('played_at > ?', date) }
+  scope :played_before, ->(date) { where(played_at: ...date) }
+  scope :played_after, ->(date) { where(played_at: date...) }
 end
diff --git a/gemset.nix b/gemset.nix
diff --git a/test/controllers/auth_tokens_controller_test.rb b/test/controllers/auth_tokens_controller_test.rb
@@ -21,7 +21,7 @@ class AuthTokensControllerTest < ActionDispatch::IntegrationTest
       }
     end
 
-    assert_response 201
+    assert_response :created
   end
 
   test 'should not create auth_token with wrong credentials' do
@@ -62,6 +62,6 @@ class AuthTokensControllerTest < ActionDispatch::IntegrationTest
       delete auth_token_url(auth_token)
     end
 
-    assert_response 204
+    assert_response :no_content
   end
 end
diff --git a/test/controllers/plays_controller_test.rb b/test/controllers/plays_controller_test.rb
@@ -34,7 +34,7 @@ class PlaysControllerTest < ActionDispatch::IntegrationTest
       post plays_url, params: { play: { played_at: DateTime.current, track_id: @track.id } }
     end
 
-    assert_response 201
+    assert_response :created
     assert_equal Play.first.user_id, @user.id
   end
 
@@ -43,7 +43,7 @@ class PlaysControllerTest < ActionDispatch::IntegrationTest
       post plays_url, params: { play: { played_at: nil, track_id: @track.id } }
     end
 
-    assert_response 422
+    assert_response :unprocessable_entity
   end
 
   test 'should get stats and  not return play stats for other users' do