Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to singularity 3.9.0 #19

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ltalirz
Copy link

@ltalirz ltalirz commented Nov 25, 2021

No description provided.

@ltalirz
Copy link
Author

ltalirz commented Nov 25, 2021

@lecorguille With the current github actions configuration the workflow won't run on a feature branch on my fork. I suggest running the tests simply on all branches.

I tested the changes from this PR, and on the VM where I ran them, they resulted in a problem here (e.g. go get is now deprecated).

Is there a particular reason why you are not following the steps described in the singularity docs, i.e. ./mconfig followed by make -C builddir? For me, the go get step was then not needed.

@lecorguille
Copy link
Member

Is there a particular reason why you are not following the steps described in the singularity docs, i.e. ./mconfig followed by make -C builddir? For me, the go get step was then not needed.

At some point, the go get step was in the instructions I sticked, I guess. Help yourself in order to adapt to the "new" installation procedure.

@lecorguille With the current github actions configuration the workflow won't run on a feature branch on my fork. I suggest running the tests simply on all branches.

Strange. I'm more used about the GitLab-Ci syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants