Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to test #82

Merged
merged 5 commits into from
Mar 27, 2024
Merged

merge dev to test #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5dac9be
Version 0.0.9-SNAPSHOT [skip ci]
Mar 25, 2024
2cad4ca
change log debug to log error
SamuelQuetin Mar 25, 2024
bafd520
Merge pull request #80 from abes-esr/CDE-396-cas-de-non-reponse-des-w…
pierre-maraval Mar 25, 2024
d6193eb
ajout controle noticeLiée supp
Mar 26, 2024
bc7920a
Merge pull request #81 from abes-esr/CDE-390_https_/abes-esr.atlassia…
EryneKL Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</parent>
<groupId>fr.abes</groupId>
<artifactId>sudoc</artifactId>
<version>0.0.8</version>
<version>0.0.9-SNAPSHOT</version>
<packaging>jar</packaging>
<name>sudoc</name>
<description>webservices de récupération de ppns dans le sudoc</description>
Expand Down
14 changes: 8 additions & 6 deletions src/main/java/fr/abes/sudoc/controller/SudocController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public ResultWsDto onlineIdentifier2Ppn(@PathVariable String type, @PathVariable
log.error("erreur dans la récupération de la notice correspondant à l'identifiant " + onlineIdentifier);
throw new IOException(ex);
} catch (IllegalPpnException ex) {
log.debug("Impossible de retrouver une notice correspondant à cet identifiant");
log.error("Impossible de retrouver une notice correspondant à l'identifiant " + onlineIdentifier);
throw new IOException(ex);
}
return resultat;
Expand Down Expand Up @@ -94,11 +94,13 @@ public ResultWsDto printIdentifier2Ppn(@PathVariable String type, @PathVariable
} else {
for (String ppnLie : ppnElect) {
NoticeXml noticeLiee = noticeService.getNoticeByPpn(ppnLie);
try {
resultat.addPpn(new PpnWithTypeWebDto(noticeLiee, this.providerService.checkProviderDansNoticeGeneral(providerDto, noticeLiee)));
} catch (IOException ex) {
resultat.addPpn(new PpnWithTypeWebDto(noticeLiee, false));
resultat.addErreur("Impossible d'analyser le provider en raison d'un problème technique, poursuite du traitement");
if(!noticeLiee.isDeleted()) {
try {
resultat.addPpn(new PpnWithTypeWebDto(noticeLiee, this.providerService.checkProviderDansNoticeGeneral(providerDto, noticeLiee)));
} catch (IOException ex) {
resultat.addPpn(new PpnWithTypeWebDto(noticeLiee, false));
resultat.addErreur("Impossible d'analyser le provider en raison d'un problème technique, poursuite du traitement");
}
}
}
}
Expand Down
Loading