Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Intent behavior of PlayerActivity #181

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

s12f
Copy link
Contributor

@s12f s12f commented Dec 20, 2024

I am trying to set mpvKt as external player of Jellyfin, and found some problems:

  1. playback tracking:
    1. mptKv failed to handle the "position" in the intent extras(reason: set player.timePos too early, the MPV is not loaded, and reports Property Unavailable Errors)
    2. Jellyfin failed to handle the result "position" in the intent extras(reason: jellyfin need to read the intent action and do some ad-hoc works)
  2. external subtitles with movie: mpvKt didn't load the external subtitles

So this PR is trying to solve those problems:

In the PR, I tests with jellyfin-android with a new PR(jellyfin/jellyfin-android#1531), it works perfect now.

related Issue: jellyfin/jellyfin-android#1481

@abdallahmehiz abdallahmehiz merged commit 1e8969b into abdallahmehiz:main Dec 21, 2024
@s12f s12f deleted the improve_PlayerActivity_intent branch December 21, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants