Improve Intent behavior of PlayerActivity #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to set mpvKt as external player of Jellyfin, and found some problems:
So this PR is trying to solve those problems:
setIntentExtras(..)
function, and I check the mpv-android implement, it uses theonloadCommands
(https://github.com/mpv-android/mpv-android/blob/5dca6eb229055a99b0cec5ddd67fc68c78295150/app/src/main/java/is/xyz/mpv/MPVActivity.kt#L272) to delay the timing, so I delay thesetIntentExtras(..)
function call after receiving MPV_EVENT_FILE_LOADED event.action
into the result intentIn the PR, I tests with jellyfin-android with a new PR(jellyfin/jellyfin-android#1531), it works perfect now.
related Issue: jellyfin/jellyfin-android#1481