Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for authentication in testing #142

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Fix for authentication in testing #142

merged 6 commits into from
Dec 10, 2024

Conversation

LokeSGJ
Copy link
Contributor

@LokeSGJ LokeSGJ commented Dec 9, 2024

Description

There was a major bug with authentication in testing where tests were not actually evaluating our auth policies, so we could not see if endpoints with authorization were working or not. With these changes, the testing environment should behave nearly the same as the production environment.

Since I was making big changes to every test, I also took the opportunity to streamline our test data seeders. The module is now much smaller and provides consistent and flexible data seeding with the methods in the DbSeeder class.

Three tests are still failing. They are all DELETE tests, and should be fixed by the changes on the Postgres branch. I've left them as they are to avoid needless merge conflicts.

Checklist

  • My code is in the right place.\
  • My code fully addresses the issue I was working on.\
  • I have added appropriate tests and error handling.\
  • My code follows the style guidelines.\
  • I have added relevant comments explaining the purpose and function of my code (if necessary).\
  • [] I have added relevant documentation to the GitHub wiki.\
  • I have created a pull request and notified the teams.

@LokeSGJ LokeSGJ merged commit 59621c8 into main Dec 10, 2024
1 check passed
@LokeSGJ LokeSGJ deleted the test-auth-fix branch December 10, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants