Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added in 'cflags!': [ '-fno-exceptions' ],
'cflags_cc!': [ '-fno-exceptions' ], to binding.gyp because if I am trying to process images in a queue and I try to hash an image that is malformed or just not existent or does not have the rights to read for some reason I get something like the following
[CImg] *** CImgIOException *** [instance(0,0,0,0,0x0,non-shared)] CImg::load(): Failed to recognize format of file '/Users/bryan/projects/repositories/secondweownit/weownit/public/uploads/images/54ca/54ca0ac949f1d8c972000005/1223cbTHUMB-chagrin-falls-patriotic-debate.jpg'.
node(7178,0x1055e1000) malloc: *** error for object 0x101040a00: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
after which my process queue shuts down and I can't keep processing the next images that do work.
If however I can catch the exceptions my queue can register the errors and keep merrily chugging along.
It's not necessarily the best solution, so you may want to do other things to allow processing of errors.
Thanks for your work on this.