Add zizmor pre-commit hook #195
Merged
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via `pre-commit autoupdate`.
2 tasks
nicholasjng
force-pushed
the
add-zizmor
branch
from
a33291b to
e052e4c
Compare
…e action Based on zizmor's findings. Fixing mike works by supplying the shell command-line inputs as envvars, since they are always fully expanded by the shell, preventing surprise injections at the template level.
nicholasjng
force-pushed
the
add-zizmor
branch
from
e052e4c to
36234b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors the same change in aai-institute/lakefs-spec#311.
Findings include the frequently missing
persist-credentials, and a template injection hint for our mike action, which appears three times (?).