Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit autoupdate, rename decorator test file #191

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

nicholasjng
Copy link
Collaborator

As stated in the title.

pytest-memray will be used to track memory usage for benchmark families
when switching to iterators.
This is more in line with the actual filename in nnbench.
@nicholasjng
Copy link
Collaborator Author

Since memray is not supported on Windows, we have to mark all upcoming memory usage tests with pytest.mark.skipif(platform.system == "Windows", ...).

Since memray is not even installable on Windows, it might require moving everything to a proper test module and skipping the complete module if we're on Windows, to avoid import errors.

@nicholasjng nicholasjng merged commit 926459d into main Dec 18, 2024
14 checks passed
@nicholasjng nicholasjng deleted the add-test-coverage branch December 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant