Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nnbench CLI guide #179

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Add nnbench CLI guide #179

merged 3 commits into from
Dec 2, 2024

Conversation

nicholasjng
Copy link
Collaborator

Contains all commands, their usages and use scenarios, and an appendix section on how to configure the CLI experience via pyproject.toml.


I also made two small tweaks to the CLI, namely printing help when calling nnbench without any arguments, and displaying the benchmark run name in comparison tables rendered by nnbench compare.

…omparison

This makes it easier to see which records the rows come from.
Contains all commands, their usages and use scenarios, and an appendix section
on how to configure the CLI experience via `pyproject.toml`.
Copy link
Collaborator

@maxmynter maxmynter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

(Feel free to add my comments to the backlog or drop them if you disagree).

docs/guides/cli.md Outdated Show resolved Hide resolved
docs/guides/cli.md Outdated Show resolved Hide resolved
docs/guides/cli.md Outdated Show resolved Hide resolved
@nicholasjng
Copy link
Collaborator Author

Agree 100% on all points - will add them over the course of the evening.

This is the most sensible configuration I can think of. We can decide if
we want to restructure the documents currently under "User Guide" into a
section such as "Python SDK".
@nicholasjng nicholasjng merged commit 4b0d1a7 into main Dec 2, 2024
14 checks passed
@nicholasjng nicholasjng deleted the add-cli-guide branch December 2, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants