feat(marketmaker): encrypt eth private key and cryptowatch api key #86
Conversation
|
Hey, thanks for makeing this PR. But this would make it impossible to restart bots automatically. Also this cant be used on services like heroku. We could merge it, if you change it to a optional feature. |
Hi Trooper, I have submitted another commit which change this feature to an optional choice |
| @@ -22,6 +25,13 @@ let FEE_TOKEN = null; | |||
| let uniswap_error_counter = 0; | |||
| let chainlink_error_counter = 0; | |||
|
|
|||
| // Encrypt the eth private key and cryptowatch api key if you want | |||
| let args = minimist(process.argv.slice(2), {boolean: 'encrypt-key'}); | |||
There was a problem hiding this comment.
This should use the config.json as well. I would sugest adding a entry like: "encryptKey": true
Then do the if check like: if(MM_CONFIG?.encryptKey)
Dont think it is a good idea to change the usage for this function. We controlle verything else using the config as well.
use
crypto-jsto encrypt the private key and api key in the config.json