Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dark mode by updating bulma and dart-sass #663

Merged
merged 29 commits into from
Oct 4, 2024
Merged

Conversation

werthen
Copy link
Member

@werthen werthen commented Sep 26, 2024

Dark mode, Bulma v1, removed yarn dependency, general updates to colours and such as well. No major things have changed in a breaking way (as far as I can see)

Closes #439

image

@zeuswpi-bot
Copy link

Check out the preview on https://663.pr.zeus.gent/

@werthen werthen marked this pull request as draft September 26, 2024 10:55
@werthen werthen marked this pull request as ready for review September 26, 2024 13:26
@werthen werthen changed the title WIP: Introduce dark mode by updating bulma and dart-sass Introduce dark mode by updating bulma and dart-sass Sep 26, 2024
@redfast00
Copy link
Member

Zal het reviewen als het build, maar ziet er veelbelovend uit :D

@werthen
Copy link
Member Author

werthen commented Sep 27, 2024

De build faalt nu ff enkel omdat ik aan het prutsen was met de actions

@werthen
Copy link
Member Author

werthen commented Sep 27, 2024

Ah nee nu faalt die door een verslag die een link heeft die naar nergens leidt 😅 dus de master zal allicht ook beginnen falen

@xerbalind
Copy link
Member

Ah nee nu faalt die door een verslag die een link heeft die naar nergens leidt 😅 dus de master zal allicht ook beginnen falen

fixed

Copy link
Member

@redfast00 redfast00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb een aantal pagina's bekeken, looks good!

@niknetniko
Copy link
Member

Would it be something to modify the underline code of the headers to this:

.underline--magical {
  background-image: -webkit-linear-gradient(
    to right,
    $zeus-orange,
    var(--bulma-body-background-color) // <--- changed this
  ); /* Chrome 10-25, Safari 5.1-6 */
  background-image: linear-gradient(
    to right,
    $zeus-orange,
    var(--bulma-body-background-color)  // <--- changed this
  ); /* W3C, IE 10+/ Edge, Firefox 16+, Chrome 26+, Opera 12+, Safari 7+ */
  background-repeat: no-repeat;
  background-size: 100% 0.15em;
  background-position: 0 99%;
}

This prevents the underline to be a bit meh in my opinion (see "Upcoming events" and compare to screenshot in original post):
image

@werthen
Copy link
Member Author

werthen commented Oct 3, 2024

Pls merge @Topvennie

@redfast00
Copy link
Member

@werthen wat denk je van niko zn comment?

@werthen
Copy link
Member Author

werthen commented Oct 4, 2024

@werthen wat denk je van niko zn comment?

Agreed en ook toegepast

@redfast00 redfast00 merged commit fc526ac into master Oct 4, 2024
1 check passed
@redfast00 redfast00 deleted the dark_mode branch October 4, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode
5 participants