Openid Connect implementation #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerbalind
force-pushed
the
openidconnect
branch
2 times, most recently
from
86c9926 to
e684bf4
Compare
xerbalind
force-pushed
the
openidconnect
branch
from
e684bf4 to
95cf19c
Compare
rien
reviewed
Oct 26, 2023
There was a problem hiding this comment.
If you want to implement OpenID with JWT completely, you might want to check out the https://github.com/Keats/jsonwebtoken crate, it seems to be the most popular crate for creating and veryfing signed JWT tokens.
I'll take a deeper look into this later, but I think we might want to add another check to see if the id_token is implemented correctly.
NuttyShrimp
approved these changes
Nov 8, 2023
rien
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows Authorization Code Flow using Oauth2.
The id_token is not yet signed as it should be, described in the specification. IMPLEMENTED
UserInfo does not yet contain the sub claim (see the specification).
The id field could be replaced with sub at
/current_useror another endpoint could be added specific for OpenId Connect.Support for scopes might be handy.
With this pull request gitea is happy 😄 (gitea does not even check the id_token signature)