make cookies samesite lax

ZeusWPI · Jul 19, 2024 · 961c939 · 961c939
1 parent 9c88038
commit 961c939
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/controllers/oauth_controller.rs b/src/controllers/oauth_controller.rs
@@ -49,7 +49,7 @@ impl AuthState {
 	}
 
 	pub fn into_cookie(self) -> Result<Cookie<'static>> {
-		Ok(Cookie::new(OAUTH_COOKIE, self.encode_b64()?))
+		Ok(Cookie::build((OAUTH_COOKIE, self.encode_b64()?)).same_site(rocket::http::SameSite::Lax).build())
 	}
 
 	pub fn from_req(

diff --git a/src/ephemeral/session.rs b/src/ephemeral/session.rs
@@ -19,7 +19,7 @@ pub fn ensure_logged_in_and_redirect(
 	cookies: &CookieJar,
 	uri: Origin,
 ) -> Redirect {
-	cookies.add_private(Cookie::new(REDIRECT_COOKIE, uri.to_string()));
+	cookies.add_private(Cookie::build((REDIRECT_COOKIE, uri.to_string())).same_site(rocket::http::SameSite::Lax));
 	Redirect::to(uri!(new_session))
 }
 
@@ -45,11 +45,11 @@ impl SessionCookie {
 		SessionCookie {
 			session_id: session.id,
 		}
-	}
+	}	
 
 	pub fn login(self, cookies: &CookieJar) {
 		let session_str = serde_urlencoded::to_string(self).unwrap();
-		let session_cookie = Cookie::new(SESSION_COOKIE, session_str);
+		let session_cookie = Cookie::build((SESSION_COOKIE, session_str)).same_site(rocket::http::SameSite::Lax);
 		cookies.add_private(session_cookie);
 	}