Add linting workflow + cleanup #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the linting output is it's not failing on this for now, it did fail on undefined names, |
|
made it fail |
|
wip, should short circuit if reason is reason in doorkeeper |
JensTimmerman
changed the title
JensTimmerman
commented
Jan 13, 2022
|
|
||
| def get_mattermost_id(username): | ||
| '''Given a mattermost username, return the user id. Don't call this with stale data''' | ||
| try: | ||
| response = mm_driver.users.get_user_by_username(username) | ||
| return response['id'] | ||
| except: | ||
| # TODO: only KeyError? | ||
| except Exception: |
There was a problem hiding this comment.
it's unclear to me what other exceptions are being caught here now, should be more specific, but at least the app will now do more clear things on interupts (keyboardinterupt etc are no longer caught)
|
No longer wip, please review |
redfast00
requested changes
Jan 14, 2022
| @@ -125,14 +125,22 @@ def authorize(admin_user): | |||
| tokens = request.values.get('text').strip().split() | |||
| if not tokens: | |||
| # list authorized user | |||
| response = '\n'.join(f'{"**" if u.admin else ""}{u.username}{" ADMIN**" if u.admin else ""}' for u in models.User.query.filter_by(authorized=True).order_by(models.User.username)) | |||
There was a problem hiding this comment.
Ik vond de originele code hier properder, maar ik zal wss in de minderheid zijn. De nieuwe code zet ook op de laatste lijn een newline, dat is niet nodig in principe.
There was a problem hiding this comment.
Ja, het is niet beter, ik herwerk
| to_authorize_username = get_actual_username(tokens[0]) | ||
| to_authorize_id = get_mattermost_id(to_authorize_username) | ||
| if to_authorize_id is None: | ||
| return mattermost_response("User '{}' does not seem to exist in Mattermost".format(to_authorize_username), ephemeral=True) | ||
| return mattermost_response( | ||
| "User '{}' does not seem to exist in Mattermost".format(to_authorize_username), |
There was a problem hiding this comment.
We hebben tegenwoordig f-strings in de Pythonversie van de server, dat is mss properder
| @@ -8,5 +8,3 @@ | |||
| os.execl(INTERP, INTERP, *sys.argv) | |||
|
|
|||
| sys.path.append(os.getcwd()) | |||
|
|
|||
| from app import app as application | |||
There was a problem hiding this comment.
iirc hebben we dit wel nodig door de manier waarop passenger werkt
| @@ -1 +0,0 @@ | |||
| from app.app import app | |||
There was a problem hiding this comment.
Ik denk dat we dit wel nodig hebben door de manier waarop either passenger of flask werkt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto linting tests are nice
they brought up some issues, so fixed those here as well