Feat: libraries #25
Open
Feat: libraries #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuttyShrimp
requested changes
Dec 1, 2023
Comment on lines
+38
to
+46
| { | ||
| showDetails ? | ||
| <> | ||
| <Text style={styles.smallText}>{library.email}</Text> | ||
| <Text style={styles.smallText}>{library.telephone}</Text> | ||
| </> | ||
| : | ||
| <></> | ||
| } |
There was a problem hiding this comment.
Could you move this details + the opening hours to a different screen using react-navigation/stack?
Comment on lines
+54
to
+56
| <Pressable style={{...styles.button, backgroundColor: "#ddd"}} onPress={() => WebBrowser.openBrowserAsync(library.link)}> | ||
| <Text>Go to site</Text> | ||
| </Pressable> |
There was a problem hiding this comment.
Also move this to the details screen and replace it with a button from react-native-paper or move it behind an icon in the header of the details screen
Comment on lines
+9
to
+17
| const schamperQuery = useSuspenseQuery<LibraryRequest, Error>({ | ||
| queryKey: ["libraries"], | ||
| queryFn: async () => { | ||
| const res = await fetch(`${ENDPOINTS.LIBRARIES}/library_groups/main.json`); | ||
| return res.json(); | ||
| }, | ||
| notifyOnChangeProps, | ||
| }); | ||
| return schamperQuery; |
There was a problem hiding this comment.
schamperQuery -> libraryQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.