Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for Tap/Tab #568

Merged
merged 21 commits into from
May 25, 2022
Merged

Add integration for Tap/Tab #568

merged 21 commits into from
May 25, 2022

Conversation

niknetniko
Copy link
Member

@niknetniko niknetniko commented May 16, 2022

This PR adds support for Tap and Tab, inspired by Tappb.

Current supported features:

  • View all Tap products
  • View all Tab transactions
  • View account balance
  • Create new Tab transactions
  • Create new Tap orders (including barcode scanning of products)
  • Manage credentials

This "Zeus mode" is hidden by default; you need to press Zeus in the about screen twice to enable it. Once enabled, access it from the navigation drawer or use the launcher shortcut (if your launcher supports it).

Most of the basics, error handling and UI are done. Some work remains:

  • Fix a crash in the manual selector for Tap orders
  • See if some testing can be done (Test Tab/Tap integration #569)
  • Find a barcode scanning solution for the open variant of the app
  • Fix linter, yet again

Future work:

  • Autocomplete other people in Tab requests (requires API support)
  • Show profile pictures of other people (requires API support)
  • Better login method (manually specifying username, Tap API key and Tab API key is not needed, probably requires API support)
  • Haldis? Maybe? Perhaps very difficult for the menu items, and not a lot of upsides
  • Integrate with favourite items in Tap
  • Allow shortcut to order favourite item directly
  • ...?

Some screenshots:
combined

@niknetniko niknetniko marked this pull request as ready for review May 25, 2022 19:14
@niknetniko niknetniko merged commit 3475462 into master May 25, 2022
@niknetniko niknetniko deleted the zeus branch May 25, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant