Automatic releases #308
Merged
Automatic releases #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niknetniko
force-pushed
the
auto-release
branch
from
1253894 to
c94fd29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the long term, these automatic releases could be pushed to the Play Store automatically.
Security wise, the risk is not 0%: it is possible to get the keystore file from the actions. However, this requires write-access to the repo, which means it basically boils down to if we trust Zeus WPI members or not. (I assume we do).
Note that other repositories with automatic deployment, such as https://github.com/ZeusWPI/hydra and https://github.com/ZeusWPI/zeus.ugent.be have the same problem.
However, one complication is that the Android keystore cannot be changed. In the case of the other repo's, we can always change SSH keys on the server.
For this reason, I suggest we wait until we have implemented App signing by Google Play, which would allow us to request a reset of the key in the action.
This last bit is blocked by #307.