vinvoor: lint & format update

.githooks/pre-commit

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+# some (*)nix distros dont have /bin/bash
+
+echo "Frontend linting"
+(cd vinvoor && pnpm --silent run precommit:lint)
+if [ $? -ne 0 ]; then
+    echo "Frontend linting failed. Please fix the errors before committing."
+    exit 1
+fi
+
+echo "Frontend typecheck"
+(cd vinvoor && pnpm --silent run precommit:typecheck)
+if [ $? -ne 0 ]; then
+    echo "Frontend type checking failed. Please fix the errors before committing."
+    exit 1
+fi

.github/workflows/vinvoor_format_lint.yml → .github/workflows/vinvoor.yml

@@ -1,16 +1,10 @@
-name: Format and linting
+name: Vinvoor Format, Lint & Typecheck
 
 on:
   push:
     branches:
       - main
-    paths:
-      - .github/workflows/vinvoor_format_lint.yml
-      - 'vinvoor/**'
   pull_request:
-    paths:
-      - .github/workflows/vinvoor_format_lint.yml
-      - 'vinvoor/**'
 
 jobs:
   format-and-lint:
@@ -20,10 +14,10 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Set up Node.js
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 20.15.1
+          node-version: 22.8.0
 
       - name: Install pnpm
         run: npm install -g pnpm
@@ -32,10 +26,10 @@ jobs:
         run: pnpm install
         working-directory: vinvoor/
 
-      - name: Run formatter
-        run: pnpm prettier --check .
+      - name: Run format & lint
+        run: pnpm eslint .
         working-directory: vinvoor/
 
-      - name: Run Linter
-        run: pnpm eslint . --max-warnings=0
+      - name: Run typecheck
+        run: pnpm tsc --noEmit
         working-directory: vinvoor/

vinvoor/eslint.config.mjs

@@ -1,28 +1,24 @@
-import { includeIgnoreFile } from "@eslint/compat";
-import eslint from "@eslint/js";
-import eslintConfigPrettier from "eslint-config-prettier";
-import path, { dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-import tseslint from "typescript-eslint";
+import antfu from "@antfu/eslint-config";
 
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const gitignorePath = path.resolve(__dirname, ".gitignore");
-
-export default tseslint.config(
-  eslint.configs.recommended,
-  ...tseslint.configs.recommendedTypeChecked,
-  ...tseslint.configs.stylisticTypeChecked,
-  includeIgnoreFile(gitignorePath),
+export default antfu(
   {
-    languageOptions: {
-      parserOptions: {
-        projectService: true,
-        tsconfigRootDir: __dirname,
-      },
+    stylistic: {
+      quotes: "double",
+      semi: true,
+    },
+
+    react: true,
+
+    typescript: {
+      tsconfigPath: "./tsconfig.json",
+    },
+
+    formatters: true,
+
+    rules: {
+      "react-hooks/exhaustive-deps": "off",
+      "ts/switch-exhaustiveness-check": "off",
+      "ts/strict-boolean-expressions": "off",
     },
   },
-  {
-    ignores: ["eslint.config.mjs", ".eslintrc.cjs"],
-  },
-  eslintConfigPrettier,
 );

vinvoor/package.json

@@ -1,8 +1,8 @@
 {
   "name": "vinvoor",
-  "private": true,
-  "version": "0.0.0",
   "type": "module",
+  "version": "0.0.0",
+  "private": true,
   "scripts": {
     "dev": "vite",
     "host": "vite --host",
@@ -42,8 +42,6 @@
     "@types/node": "^22.9.0",
     "@types/react": "^18.3.12",
     "@types/react-dom": "^18.3.1",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
     "@vitejs/plugin-react-swc": "^3.7.1",
     "eslint": "^9.15.0",
     "eslint-config-prettier": "^9.1.0",