Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TwinCAT Dynamic Collections #4

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

fisothemes
Copy link
Contributor

Added TwinCAT Dynamic Collections library.

@fisothemes fisothemes changed the title Update repositories.txt Added TwinCAT Dynamic Collections Jul 27, 2024
@iadonkey iadonkey merged commit 9f09ccf into Zeugwerk:main Jul 27, 2024
@iadonkey
Copy link
Contributor

Merged it, but looks like GitHub changed something in the API used for getting the last release. Will look into it latest in Monday and keep you posted

@iadonkey
Copy link
Contributor

Zeugwerk/Twinpack#132

@fisothemes
Copy link
Contributor Author

It might be because I marked it as a Pre-release. Whenever you're ready I could try marking it as a Release.
Thanks again for Twinpack and enjoy the weekend 👍

@iadonkey
Copy link
Contributor

Ah, might be, anyway I want to debug this issue, we want to make using the Twinpack registry as simple to us as possible

@iadonkey
Copy link
Contributor

@fisothemes looked into it and the error is actually popping up because all the releases of your repo are pre-releases. I changed the error message a bit, so it is clear what is going on (see https://github.com/Zeugwerk/Twinpack/actions/runs/10126231685/job/28002851708#step:2:57).

We don't have support yet for pre-releases, but I added an issue Zeugwerk/Twinpack#133 to support pre-releases. Not sure, when we'll get to this. The goal of the next release of Twinpack is to improve the commandline interface.

However, anytime you'll publish a release as 'official' (without the 'pre-release' checkbox), twinpack-registry will pick it up and it will be available in Twinpack. You can also do it for any of the already published (pre-)releases, just edit the release and untick the 'pre-release checkbox'. The GitHub workflow for checking for releases runs automatically once a day (see https://github.com/Zeugwerk/Twinpack/actions)

@fisothemes
Copy link
Contributor Author

I originally marked it as pre-release because I had few more data structures to add. I've been using the library heavily for a while now and it's stable enough to be marked as release, I've done that for the last pre-release.

Thanks again for spending some time to look into this, no need to rush, I'm not fussed, it's a small change on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants