Feature/refactor introduce ResolvingType #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just os that I dont check in test exports
Resolving types know their TypeID by now
kindlich
commented
Aug 31, 2024
| @@ -27,7 +27,7 @@ public GenericName(String name, TypeID[] arguments) { | |||
| public static Optional<TypeID> getInnerType(TypeID type, List<GenericName> name, int index, List<ExpansionSymbol> expansions) { | |||
| while (index < name.size()) { | |||
| GenericName innerName = name.get(index++); | |||
| ResolvedType members = type.resolve(); | |||
| ResolvedType members = type.resolve().withExpansions(expansions); | |||
There was a problem hiding this comment.
❓ Question: Do we even need the expansions here or could we remove that argument altogether and type.resolveWithoutExpansions()
There was a problem hiding this comment.
Good point, we may not need it here.
stanhebben
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.