-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Created text input #78
Conversation
Visit the preview URL for this PR (updated for commit 493980b): https://zeta-flutter-main--pr-78-text-input-qx4hdnln.web.app (expires Thu, 30 May 2024 10:32:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
@@ -32,13 +32,12 @@ Widget dateInputUseCase(BuildContext context) { | |||
child: ZetaDateInput( | |||
size: size, | |||
rounded: rounded, | |||
enabled: enabled, | |||
disabled: enabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong way around
late final String _hintText; | ||
/// State for [ZetaDateInput] | ||
class ZetaDateInputState extends State<ZetaDateInput> implements ZetaFormFieldState { | ||
// TODO(mikecoomber): add AM/PM selector inline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was waiting on designs, should I just freestyle it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, sorry wasnt looking close enough. In situations like this I have been creating a Jira ticket and replacing 'mikecoomber' with the ticket number
hintText: widget.placeholder, | ||
errorText: _errorText, | ||
hintStyle: _baseTextStyle, | ||
errorStyle: const TextStyle(height: 0.001, color: Colors.transparent), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting...
could you use 0 to fully hide it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly that wasn't actually hiding the text in some cases, found this as a workaround
refactor: Refactored date and time inputs to use text input
refactor: Refactored date and time inputs to use text input