Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Created text input #78

Merged
merged 7 commits into from
May 23, 2024
Merged

feat: Created text input #78

merged 7 commits into from
May 23, 2024

Conversation

mikecoomber
Copy link
Collaborator

@mikecoomber mikecoomber commented May 22, 2024

refactor: Refactored date and time inputs to use text input

Copy link
Contributor

github-actions bot commented May 22, 2024

Visit the preview URL for this PR (updated for commit 493980b):

https://zeta-flutter-main--pr-78-text-input-qx4hdnln.web.app

(expires Thu, 30 May 2024 10:32:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6

lib/src/components/time_input/time_input.dart Show resolved Hide resolved
example/lib/pages/components/date_input_example.dart Outdated Show resolved Hide resolved
@@ -32,13 +32,12 @@ Widget dateInputUseCase(BuildContext context) {
child: ZetaDateInput(
size: size,
rounded: rounded,
enabled: enabled,
disabled: enabled,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong way around

lib/src/components/date_input/date_input.dart Outdated Show resolved Hide resolved
late final String _hintText;
/// State for [ZetaDateInput]
class ZetaDateInputState extends State<ZetaDateInput> implements ZetaFormFieldState {
// TODO(mikecoomber): add AM/PM selector inline.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was waiting on designs, should I just freestyle it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sorry wasnt looking close enough. In situations like this I have been creating a Jira ticket and replacing 'mikecoomber' with the ticket number

lib/src/components/text_input/text_input.dart Show resolved Hide resolved
hintText: widget.placeholder,
errorText: _errorText,
hintStyle: _baseTextStyle,
errorStyle: const TextStyle(height: 0.001, color: Colors.transparent),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting...
could you use 0 to fully hide it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly that wasn't actually hiding the text in some cases, found this as a workaround

lib/src/components/text_input/text_input.dart Show resolved Hide resolved
@mikecoomber mikecoomber changed the title feature/text-input feat: Created text input May 23, 2024
@mikecoomber mikecoomber merged commit 2f1d149 into main May 23, 2024
5 checks passed
thelukewalton added a commit that referenced this pull request May 23, 2024
refactor: Refactored date and time inputs to use text input
@thelukewalton thelukewalton deleted the text-input branch May 24, 2024 14:11
This was referenced Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants