-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Navigation Bar #213
Merged
Merged
test: Navigation Bar #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: made NavigationItem visible for testing fix: Changed font size of medium indicator from 12 to 11
test: added more tests for navigation bar
test: edited test to pass after merge
DE7924
requested review from
benken,
mikecoomber and
thelukewalton
as code owners
November 13, 2024 13:23
PR Checks complete
Created with Flutter code quality action |
Visit the preview URL for this PR (updated for commit ca8cd53): https://zeta-flutter-main--pr-213-tests-navigation-bar-co9lkeyh.web.app (expires Mon, 25 Nov 2024 12:00:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
fix: navigation bar semantic labels
…eta_flutter into tests-navigation-bar
…eta_flutter into tests-navigation-bar
thelukewalton
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.