-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UX-922): FAB-redesign #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: added expanded knob to widgetbook
DE7924
requested review from
benken,
mikecoomber and
thelukewalton
as code owners
September 25, 2024 13:44
PR Checks complete
Created with Flutter code quality action |
Visit the preview URL for this PR (updated for commit 7c185c8): https://zeta-flutter-main--pr-181-ux-922-fab-redesign-r4rs6tc3.web.app (expires Fri, 11 Oct 2024 13:46:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
mikecoomber
reviewed
Oct 1, 2024
fix: constrained the width of the label to 100 so it wraps if it's too long. Let me know if you have a better solution that mine
mikecoomber
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: added expanded knob to widgetbook
fix: added label to non-expanded fab