Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow custom icons in ZetaFilterSelection #152

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix: Allow custom icons in ZetaFilterSelection #152

merged 2 commits into from
Aug 19, 2024

Conversation

thelukewalton
Copy link
Collaborator

No description provided.

@thelukewalton thelukewalton marked this pull request as ready for review August 17, 2024 06:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 17, 2024 •
edited
Loading

PR Checks complete

  • ✅ - Linting / Formatting
  • ✅ - Static analysis passed
  • ✅ - All tests passed
  • ✅ - Branch is not behind
  • 📈 - Code coverage: 34.56% (🔻 down from 34.59%)
    See details
    File Name%Passing?
    lib/src/theme/contrast.dart100%✅
    lib/src/theme/theme_data.dart100%✅
    lib/src/utils/zeta.dart100%✅
    lib/src/components/accordion/accordion.dart100%✅
    lib/src/utils/rounded.dart100%✅
    lib/src/components/avatars/avatar.dart0%⛔️
    lib/src/components/badges/indicator.dart98.3%✅
    lib/src/components/badges/label.dart100%✅
    lib/src/components/badges/priority_pill.dart100%✅
    lib/src/components/badges/status_label.dart100%✅
    lib/src/components/badges/tag.dart98.4%✅
    lib/src/components/banner/banner.dart0%⛔️
    lib/src/components/bottom sheets/bottom_sheet.dart0%⛔️
    lib/src/components/bottom sheets/menu_items.dart0%⛔️
    lib/src/components/breadcrumbs/breadcrumbs.dart0%⛔️
    lib/src/components/button_group/button_group.dart0%⛔️
    lib/src/components/buttons/button.dart97.4%✅
    lib/src/components/buttons/button_style.dart100%✅
    lib/src/components/buttons/icon_button.dart54.1%⛔️
    lib/src/components/buttons/input_icon_button.dart73.3%⛔️
    lib/src/components/chat_item/chat_item.dart0%⛔️
    lib/src/components/checkbox/checkbox.dart100%✅
    lib/src/components/chips/assist_chip.dart0%⛔️
    lib/src/components/chips/chip.dart71.3%⛔️
    lib/src/components/chips/filter_chip.dart0%⛔️
    lib/src/components/chips/input_chip.dart0%⛔️
    lib/src/components/contact_item/contact_item.dart0%⛔️
    lib/src/components/date_input/date_input.dart0%⛔️
    lib/src/components/dial_pad/dial_pad.dart100%✅
    lib/src/components/dialog/dialog.dart0%⛔️
    lib/src/components/dropdown/dropdown.dart0%⛔️
    lib/src/components/fabs/fab.dart100%✅
    lib/src/components/filter_selection/filter_selection.dart0%⛔️
    lib/src/components/global_header/global_header.dart0%⛔️
    lib/src/components/global_header/header_tab_item.dart0%⛔️
    lib/src/components/icon/icon.dart100%✅
    lib/src/components/in_page_banner/in_page_banner.dart100%✅
    lib/src/components/list_item/dropdown_list_item.dart0%⛔️
    lib/src/components/list_item/list_item.dart0%⛔️
    lib/src/components/list_item/notification_list_item.dart0%⛔️
    lib/src/components/navigation bar/navigation_bar.dart0%⛔️
    lib/src/components/navigation_rail/navigation_rail.dart0%⛔️
    lib/src/components/pagination/pagination.dart0.7%⛔️
    lib/src/components/password/password_input.dart100%✅
    lib/src/components/phone_input/phone_input.dart0%⛔️
    lib/src/components/progress/progress_bar.dart0%⛔️
    lib/src/components/progress/progress_circle.dart0%⛔️
    lib/src/components/radio/radio.dart0%⛔️
    lib/src/components/screen_header_bar/screen_header_bar.dart0%⛔️
    lib/src/components/search_bar/search_bar.dart100%✅
    lib/src/components/segmented_control/segmented_control.dart0%⛔️
    lib/src/components/select_input/select_input.dart0%⛔️
    lib/src/components/slider/slider.dart81%⛔️
    lib/src/components/snack_bar/snack_bar.dart0%⛔️
    lib/src/components/stepper/stepper.dart0%⛔️
    lib/src/components/stepper_input/stepper_input.dart72.1%⛔️
    lib/src/components/switch/zeta_switch.dart0%⛔️
    lib/src/components/tabs/tab.dart0%⛔️
    lib/src/components/tabs/tab_bar.dart0%⛔️
    lib/src/components/text_input/text_input.dart0%⛔️
    lib/src/components/time_input/time_input.dart0%⛔️
    lib/src/components/tooltip/tooltip.dart98.8%✅
    lib/src/components/top_app_bar/top_app_bar.dart0%⛔️
    lib/src/interfaces/form_field.dart81.4%⛔️
    lib/src/components/text_input/internal_text_input.dart69.1%⛔️
    lib/src/components/list_item/list_scope.dart0%⛔️
    lib/src/components/phone_input/countries.dart10%⛔️
    lib/src/components/progress/progress.dart0%⛔️
    lib/src/components/switch/material_switch.dart0%⛔️
    lib/src/components/text_input/hint_text.dart70.8%⛔️
    lib/src/components/text_input/input_label.dart0%⛔️
    lib/src/components/top_app_bar/extended_top_app_bar.dart0%⛔️
    lib/src/components/top_app_bar/search_top_app_bar.dart0%⛔️
    lib/src/theme/breakpoints.dart100%✅
    lib/src/theme/color_extensions.dart100%✅
    lib/src/theme/color_swatch.dart100%✅
    lib/src/theme/color_scheme.dart100%✅
    lib/src/theme/colors.dart100%✅
    lib/src/utils/debounce.dart100%✅
    lib/src/utils/extensions.dart100%✅
    lib/src/utils/nothing.dart100%✅
    lib/src/utils/zeta_provider.dart100%✅

Created with Flutter code quality action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 616fd6b):

https://zeta-flutter-main--pr-152-fix-filter-icon-v7sfe35t.web.app

(expires Mon, 26 Aug 2024 11:29:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6

@thelukewalton
ci: Update to latest version of flutter-code-quality action
616fd6b 
chore: Remve support for deprecated buttonBarTheme in ThemeData
@thelukewalton thelukewalton merged commit a493129 into main Aug 19, 2024
4 checks passed
@thelukewalton thelukewalton deleted the fix/filter-icon branch August 19, 2024 11:38
@thelukewalton thelukewalton mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DE7924 DE7924 DE7924 approved these changes

@benken benken Awaiting requested review from benken benken is a code owner

@mikecoomber mikecoomber Awaiting requested review from mikecoomber mikecoomber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelukewalton @DE7924