Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UX-1141): Update tokens to match figma #151

Closed
wants to merge 11 commits into from
Closed

fix(UX-1141): Update tokens to match figma #151

wants to merge 11 commits into from

Conversation

thelukewalton
Copy link
Collaborator

@thelukewalton thelukewalton commented Aug 16, 2024 •
edited
Loading

feat: Refactored how primitives and semantic values are loaded into Zeta
feat: Added default implementation of ZetaThemeService using shared_preferences
fix: Changed padding on ZetaFAB, ZetaInPageBanner,
fix: Added ZetaPureColorSwatch alongside ZetaColorSwatch
chore: Apply new color, spacing and radii values to all components
chore: Added temporary values for color / radius
test: Updated tests for new colors

deprecated: ZetaColorExtensions, ZetaColorScheme, ZetaColors, ZetaColorBase, ZetaSpacing, ZetaSpacingBase, ZetaRadius, ZetaRadiusBase. These are all open for discussion due to the magnitude of this change.

--Not finished yet--

TODO: Check backwards compatibility
TODO: Revert ability to edit primary / secondary colors and create own themes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

PR Checks complete

  • ✅ - Linting / Formatting
  • ✅ - Static analysis passed
  • ✅ - All tests passed
  • ✅ - Branch is not behind
  • 📈 - Code coverage: 34.55% (🔻 down from 34.56%)
    See details
    File Name%Passing?
    lib/src/theme/contrast.dart100%✅
    lib/src/theme/theme_data.dart100%✅
    lib/src/utils/zeta.dart97.9%✅
    lib/generated/tokens/primitives.g.dart31.9%⛔️
    lib/generated/tokens/semantics.g.dart37.8%⛔️
    lib/src/components/accordion/accordion.dart100%✅
    lib/src/utils/rounded.dart100%✅
    lib/src/components/avatars/avatar.dart0%⛔️
    lib/src/components/badges/indicator.dart98.5%✅
    lib/src/components/badges/label.dart100%✅
    lib/src/components/badges/priority_pill.dart100%✅
    lib/src/components/badges/status_label.dart63.6%⛔️
    lib/src/components/badges/tag.dart98.5%✅
    lib/src/components/banner/banner.dart0%⛔️
    lib/src/components/bottom sheets/bottom_sheet.dart0%⛔️
    lib/src/components/bottom sheets/menu_items.dart0%⛔️
    lib/src/components/breadcrumbs/breadcrumbs.dart0%⛔️
    lib/src/components/button_group/button_group.dart0%⛔️
    lib/src/components/buttons/button.dart97.3%✅
    lib/src/components/buttons/button_style.dart98.9%✅
    lib/src/components/buttons/icon_button.dart51.2%⛔️
    lib/src/components/buttons/input_icon_button.dart72.7%⛔️
    lib/src/components/chat_item/chat_item.dart0%⛔️
    lib/src/components/checkbox/checkbox.dart100%✅
    lib/src/components/chips/assist_chip.dart0%⛔️
    lib/src/components/chips/chip.dart71.7%⛔️
    lib/src/components/chips/filter_chip.dart0%⛔️
    lib/src/components/chips/input_chip.dart0%⛔️
    lib/src/components/contact_item/contact_item.dart0%⛔️
    lib/src/components/date_input/date_input.dart0%⛔️
    lib/src/components/dial_pad/dial_pad.dart100%✅
    lib/src/components/dialog/dialog.dart0%⛔️
    lib/src/components/dropdown/dropdown.dart0%⛔️
    lib/src/components/fabs/fab.dart96.8%✅
    lib/src/components/filter_selection/filter_selection.dart0%⛔️
    lib/src/components/global_header/global_header.dart0%⛔️
    lib/src/components/global_header/header_tab_item.dart0%⛔️
    lib/src/components/icon/icon.dart100%✅
    lib/src/components/in_page_banner/in_page_banner.dart96.9%✅
    lib/src/components/list_item/dropdown_list_item.dart0%⛔️
    lib/src/components/list_item/list_item.dart0%⛔️
    lib/src/components/list_item/notification_list_item.dart0%⛔️
    lib/src/components/navigation bar/navigation_bar.dart0%⛔️
    lib/src/components/navigation_rail/navigation_rail.dart0%⛔️
    lib/src/components/pagination/pagination.dart0.6%⛔️
    lib/src/components/password/password_input.dart100%✅
    lib/src/components/phone_input/phone_input.dart0%⛔️
    lib/src/components/progress/progress_bar.dart0%⛔️
    lib/src/components/progress/progress_circle.dart0%⛔️
    lib/src/components/radio/radio.dart0%⛔️
    lib/src/components/screen_header_bar/screen_header_bar.dart0%⛔️
    lib/src/components/search_bar/search_bar.dart97.5%✅
    lib/src/components/segmented_control/segmented_control.dart0%⛔️
    lib/src/components/select_input/select_input.dart0%⛔️
    lib/src/components/slider/slider.dart82.3%⛔️
    lib/src/components/snack_bar/snack_bar.dart0%⛔️
    lib/src/components/stepper/stepper.dart0%⛔️
    lib/src/components/stepper_input/stepper_input.dart71.9%⛔️
    lib/src/components/switch/zeta_switch.dart0%⛔️
    lib/src/components/tabs/tab.dart0%⛔️
    lib/src/components/tabs/tab_bar.dart0%⛔️
    lib/src/components/text_input/text_input.dart0%⛔️
    lib/src/components/time_input/time_input.dart0%⛔️
    lib/src/components/tooltip/tooltip.dart98.9%✅
    lib/src/components/top_app_bar/top_app_bar.dart0%⛔️
    lib/src/interfaces/form_field.dart81.4%⛔️
    lib/src/components/text_input/internal_text_input.dart65.4%⛔️
    lib/src/components/list_item/list_scope.dart0%⛔️
    lib/src/components/phone_input/countries.dart10%⛔️
    lib/src/components/progress/progress.dart0%⛔️
    lib/src/components/switch/material_switch.dart0%⛔️
    lib/src/components/text_input/hint_text.dart74.1%⛔️
    lib/src/components/text_input/input_label.dart0%⛔️
    lib/src/components/top_app_bar/extended_top_app_bar.dart0%⛔️
    lib/src/components/top_app_bar/search_top_app_bar.dart0%⛔️
    lib/src/temp_colors.dart0%⛔️
    lib/src/theme/breakpoints.dart100%✅
    lib/src/theme/color_extensions.dart100%✅
    lib/src/theme/color_scheme.dart100%✅
    lib/src/theme/colors.dart93.5%⛔️
    lib/src/theme/color_swatch.dart94.5%⛔️
    lib/src/theme/theme_service.dart11.8%⛔️
    lib/src/theme/tokens.dart100%✅
    lib/src/utils/debounce.dart100%✅
    lib/src/utils/extensions.dart100%✅
    lib/src/utils/nothing.dart100%✅
    lib/src/utils/zeta_provider.dart92.9%⛔️

Created with Flutter code quality action

@thelukewalton thelukewalton force-pushed the chore/tokensver-2 branch 4 times, most recently from b9faef0 to e3fe839 Compare August 20, 2024 12:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1e5fa19):

https://zeta-flutter-main--pr-151-chore-tokensver-2-won0zv5i.web.app

(expires Tue, 27 Aug 2024 14:20:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6

@thelukewalton thelukewalton changed the title fix: Update tokens to match figma fix(UX-1141): Update tokens to match figma Aug 22, 2024
@thelukewalton thelukewalton deleted the chore/tokensver-2 branch December 20, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benken benken Awaiting requested review from benken benken will be requested when the pull request is marked ready for review benken is a code owner

@mikecoomber mikecoomber Awaiting requested review from mikecoomber mikecoomber will be requested when the pull request is marked ready for review mikecoomber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thelukewalton