-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UX-1129): Add didUpdateStates to StatefulWidgets #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: Accordion didUpdataState
test: Chip didUpdateState
test: FAB expanded state
…setStates and put super call first
test: Min/max values in slider
test: Stepper input didUpdateWidget
PR Checks complete
Created with Flutter code quality action |
Visit the preview URL for this PR (updated for commit 853da0b): https://zeta-flutter-main--pr-138-ux-1129-umln719p.web.app (expires Tue, 30 Jul 2024 15:15:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
mikecoomber
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Accordion didUpdateState
fix: Chip didUpdateState
fix: FAB expanded state
fix: Make Navigation rail and list item stateless, as this served no purpose
fix: Add min/max values in slider
fix: Stepper input didUpdateWidget
chore: Refactor existing didUpdateWidgets to best practices - remove setStates and put super call first
test: Accordion didUpdateState, improve accordion tests
test: Chip didUpdateState
test: FAB expanded state
test: Min/max values in slider
test: Stepper input didUpdateWidget