Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UX-1121): Added ZetaProvider.base to allow for better developer experience #123

Merged
merged 9 commits into from
Jul 3, 2024
Merged

feat(UX-1121): Added ZetaProvider.base to allow for better developer experience #123

merged 9 commits into from
Jul 3, 2024

Conversation

thelukewalton
Copy link
Collaborator

@thelukewalton thelukewalton commented Jul 2, 2024 •
edited
Loading

refactor: Added Nothing conveinience method
refactor: Move rounded property to Zeta, not ZetaThemeData
chore: Add rounded switch to example app
refactor: Implement global rounded in example app
test: Update golden tests for rounded state change

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

PR Checks complete

  • ✅ - Linting / Formatting
  • ✅ - Static analysis passed
  • ✅ - All tests passed
  • ✅ - Branch is not behind
  • 📈 - Code coverage: 27.46% (⬆️ up from 27.09%)
    See details
    File Name%Passing?
    lib/src/components/accordion/accordion.dart71.6%⛔️
    lib/src/utils/rounded.dart100%✅
    lib/src/components/avatars/avatar.dart0%⛔️
    lib/src/components/badges/indicator.dart98.3%✅
    lib/src/components/badges/label.dart100%✅
    lib/src/components/badges/priority_pill.dart100%✅
    lib/src/components/badges/status_label.dart100%✅
    lib/src/components/badges/tag.dart98.3%✅
    lib/src/components/banner/banner.dart0%⛔️
    lib/src/components/bottom sheets/bottom_sheet.dart0%⛔️
    lib/src/components/bottom sheets/menu_items.dart0%⛔️
    lib/src/components/breadcrumbs/breadcrumbs.dart0%⛔️
    lib/src/components/button_group/button_group.dart0%⛔️
    lib/src/components/buttons/button.dart97.2%✅
    lib/src/components/buttons/button_style.dart100%✅
    lib/src/components/buttons/icon_button.dart0%⛔️
    lib/src/components/buttons/input_icon_button.dart0%⛔️
    lib/src/components/chat_item/chat_item.dart0%⛔️
    lib/src/components/checkbox/checkbox.dart96.6%✅
    lib/src/components/chips/assist_chip.dart0%⛔️
    lib/src/components/chips/chip.dart0%⛔️
    lib/src/components/chips/filter_chip.dart0%⛔️
    lib/src/components/chips/input_chip.dart0%⛔️
    lib/src/components/contact_item/contact_item.dart0%⛔️
    lib/src/components/date_input/date_input.dart0%⛔️
    lib/src/interfaces/form_field.dart100%✅
    lib/src/components/dial_pad/dial_pad.dart100%✅
    lib/src/components/dialog/dialog.dart0%⛔️
    lib/src/components/dropdown/dropdown.dart0%⛔️
    lib/src/components/fabs/fab.dart96.8%✅
    lib/src/components/filter_selection/filter_selection.dart0%⛔️
    lib/src/components/global_header/global_header.dart0%⛔️
    lib/src/components/global_header/header_tab_item.dart0%⛔️
    lib/src/components/icon/icon.dart100%✅
    lib/src/components/in_page_banner/in_page_banner.dart100%✅
    lib/src/components/list_item/dropdown_list_item.dart0%⛔️
    lib/src/components/list_item/list_scope.dart0%⛔️
    lib/src/components/list_item/list_item.dart0%⛔️
    lib/src/components/list_item/notification_list_item.dart0%⛔️
    lib/src/components/navigation bar/navigation_bar.dart0%⛔️
    lib/src/components/navigation_rail/navigation_rail.dart0%⛔️
    lib/src/components/pagination/pagination.dart0.7%⛔️
    lib/src/components/password/password_input.dart100%✅
    lib/src/components/phone_input/countries.dart10%⛔️
    lib/src/components/phone_input/countries_dialog.dart0%⛔️
    lib/src/components/phone_input/phone_input.dart0%⛔️
    lib/src/components/progress/progress.dart0%⛔️
    lib/src/components/progress/progress_bar.dart0%⛔️
    lib/src/components/progress/progress_circle.dart0%⛔️
    lib/src/components/radio/radio.dart0%⛔️
    lib/src/components/screen_header_bar/screen_header_bar.dart0%⛔️
    lib/src/components/search_bar/search_bar.dart0%⛔️
    lib/src/components/segmented_control/segmented_control.dart0%⛔️
    lib/src/components/select_input/select_input.dart0%⛔️
    lib/src/components/slider/slider.dart0%⛔️
    lib/src/zeta.dart100%✅
    lib/src/components/snack_bar/snack_bar.dart0%⛔️
    lib/src/components/stepper/stepper.dart0%⛔️
    lib/src/components/stepper_input/stepper_input.dart0%⛔️
    lib/src/components/switch/material_switch.dart0%⛔️
    lib/src/components/switch/zeta_switch.dart0%⛔️
    lib/src/components/tabs/tab.dart0%⛔️
    lib/src/components/tabs/tab_bar.dart0%⛔️
    lib/src/components/text_input/text_input.dart53.7%⛔️
    lib/src/components/time_input/time_input.dart0%⛔️
    lib/src/components/tooltip/tooltip.dart98.8%✅
    lib/src/components/top_app_bar/extended_top_app_bar.dart0%⛔️
    lib/src/components/top_app_bar/search_top_app_bar.dart0%⛔️
    lib/src/components/top_app_bar/top_app_bar.dart0%⛔️
    lib/src/theme/breakpoints.dart100%✅
    lib/src/theme/color_extensions.dart100%✅
    lib/src/theme/color_swatch.dart100%✅
    lib/src/theme/contrast.dart100%✅
    lib/src/theme/color_scheme.dart100%✅
    lib/src/theme/colors.dart100%✅
    lib/src/theme/theme_data.dart100%✅
    lib/src/utils/debounce.dart100%✅
    lib/src/utils/extensions.dart100%✅
    lib/src/utils/nothing.dart100%✅
    lib/src/zeta_provider.dart88.1%⛔️

Created with Flutter code quality action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 097b57f):

https://zeta-flutter-main--pr-123-ux-1121-pjb1hbzh.web.app

(expires Wed, 10 Jul 2024 11:45:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6

@thelukewalton thelukewalton marked this pull request as draft July 2, 2024 16:43
@thelukewalton thelukewalton marked this pull request as ready for review July 3, 2024 10:37
@thelukewalton thelukewalton merged commit 3cc79b0 into main Jul 3, 2024
@thelukewalton thelukewalton deleted the UX-1121 branch July 3, 2024 11:46
This was referenced Jul 3, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecoomber mikecoomber mikecoomber approved these changes

@benken benken Awaiting requested review from benken benken is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelukewalton @mikecoomber