Skip to content

Commit

Permalink
test: Uncommented text contrast tests
Browse files Browse the repository at this point in the history
  • Loading branch information
DE7924 committed Nov 13, 2024
1 parent e16f932 commit fa7452e
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions test/src/components/navigation_bar/navigation_bar_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ void main() {
goldenFileComparator = TolerantComparator(goldenFile.uri);
});

const selectedIndex = 0;
const items = [
ZetaNavigationBarItem(icon: ZetaIcons.star, label: 'Label0', badge: ZetaIndicator(value: 2)),
ZetaNavigationBarItem(icon: ZetaIcons.star, label: 'Label1'),
Expand All @@ -42,9 +41,7 @@ void main() {
await expectLater(tester, meetsGuideline(androidTapTargetGuideline));
await expectLater(tester, meetsGuideline(iOSTapTargetGuideline));
await expectLater(tester, meetsGuideline(labeledTapTargetGuideline));

// TODO: fails accessibility due to ZetaIndicator failing text contrast
// await expectLater(tester, meetsGuideline(textContrastGuideline));
await expectLater(tester, meetsGuideline(textContrastGuideline));
});

testWidgets('meets accessibility requirements with action', (WidgetTester tester) async {
Expand All @@ -60,9 +57,7 @@ void main() {
await expectLater(tester, meetsGuideline(androidTapTargetGuideline));
await expectLater(tester, meetsGuideline(iOSTapTargetGuideline));
await expectLater(tester, meetsGuideline(labeledTapTargetGuideline));

// TODO: fails accessibility due to ZetaIndicator failing text contrast
// await expectLater(tester, meetsGuideline(textContrastGuideline));
await expectLater(tester, meetsGuideline(textContrastGuideline));
});

testWidgets('meets accessibility requirements with divider', (WidgetTester tester) async {
Expand All @@ -78,9 +73,7 @@ void main() {
await expectLater(tester, meetsGuideline(androidTapTargetGuideline));
await expectLater(tester, meetsGuideline(iOSTapTargetGuideline));
await expectLater(tester, meetsGuideline(labeledTapTargetGuideline));

// TODO: fails accessibility due to ZetaIndicator failing text contrast
// await expectLater(tester, meetsGuideline(textContrastGuideline));
await expectLater(tester, meetsGuideline(textContrastGuideline));
});

testWidgets('meets accessibility requirements with split', (WidgetTester tester) async {
Expand All @@ -95,9 +88,7 @@ void main() {
await expectLater(tester, meetsGuideline(androidTapTargetGuideline));
await expectLater(tester, meetsGuideline(iOSTapTargetGuideline));
await expectLater(tester, meetsGuideline(labeledTapTargetGuideline));

// TODO: fails accessibility due to ZetaIndicator failing text contrast
// await expectLater(tester, meetsGuideline(textContrastGuideline));
await expectLater(tester, meetsGuideline(textContrastGuideline));
});

testWidgets('items have semantic labels', (WidgetTester tester) async {
Expand Down

0 comments on commit fa7452e

Please sign in to comment.