fix: A variety of small bug fixes (#168)

ci: Update passing score to 90%
chore: Update third party licenses
fix: Add PlatformIs to not use dart:io
fix: Border sizes
fix: Spacings in example app

.github/workflows/pull-request.yml

@@ -24,7 +24,7 @@ jobs:
         - uses: ZebraDevs/flutter-code-quality@main
           with:
             token: ${{secrets.GITHUB_TOKEN}}  
-            coverage-pass-score: '1'
+            coverage-pass-score: '90'
 
 
   check-secret:

LICENSE-3RD-PARTY

@@ -2,7 +2,7 @@
 
 ---
 
-### Flutter
+## Flutter
 
 Applies to:
 
@@ -37,7 +37,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 ---
 
-### tinycolor
+## tinycolor
 
 Applies to:
 
@@ -53,7 +53,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ---
 
-### IBM Plex Sans
+## IBM Plex Sans
 
 Applies to:
 
@@ -67,7 +67,7 @@ This Font Software is licensed under the SIL Open Font License, Version 1.1.
 
 This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL
 
-## SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
+### SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
 
 PREAMBLE
 The goals of the Open Font License (OFL) are to stimulate worldwide
@@ -151,3 +151,37 @@ INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL
 DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM
 OTHER DEALINGS IN THE FONT SOFTWARE.
+
+
+
+## Mike Rydstrom
+
+Applies to:
+
+* platform_is.dart
+* universal_platform_vm.dart
+* universal_platform_web.dart
+
+https://gist.github.com/rydmike/1771fe24c050ebfe792fa309371154d8
+
+MIT License
+
+Copyright (c) 2021 Mike Rydstrom
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

example/lib/home.dart

@@ -161,30 +161,40 @@ class _HomeState extends State<Home> {
       child: SingleChildScrollView(
         child: Column(
           children: [
-            ExpansionTile(
-              title: Text('Widgets'),
-              backgroundColor: Zeta.of(context).colors.warm.shade30,
-              children: _components
-                  .map((item) => ListTile(title: Text(item.name), onTap: () => context.go('/${item.name}')))
-                  .toList(),
-            ),
-            ExpansionTile(
-              title: Text('Theme'),
-              backgroundColor: Zeta.of(context).colors.warm.shade30,
-              children: _theme
-                  .map((item) => ListTile(title: Text(item.name), onTap: () => context.go('/${item.name}')))
-                  .toList(),
-            ),
-            ExpansionTile(
-              title: Text('Assets'),
-              backgroundColor: Zeta.of(context).colors.warm.shade30,
-              children: _assets
-                  .map((item) => ListTile(title: Text(item.name), onTap: () => context.go('/${item.name}')))
-                  .toList(),
-            ),
+            ExampleListTile(name: 'Components', children: _components),
+            ExampleListTile(name: 'Theme', children: _theme),
+            ExampleListTile(name: 'Assets', children: _assets),
           ],
         ),
       ),
     );
   }
 }
+
+class ExampleListTile extends StatelessWidget {
+  const ExampleListTile({
+    super.key,
+    required this.children,
+    required this.name,
+  });
+
+  final List<Component> children;
+  final String name;
+
+  @override
+  Widget build(BuildContext context) {
+    return ExpansionTile(
+      title: Text(name),
+      children: children
+          .map(
+            (item) => ListTile(
+              title: Text(item.name),
+              onTap: () => context.go('/${item.name}'),
+              hoverColor: Zeta.of(context).colors.surfaceHover,
+              tileColor: Zeta.of(context).colors.surfaceDefault,
+            ),
+          )
+          .toList(),
+    );
+  }
+}

example/lib/pages/theme/spacing_example.dart

@@ -16,33 +16,33 @@ class SpacingExample extends StatelessWidget {
       'medium': Zeta.of(context).spacing.medium,
       'large': Zeta.of(context).spacing.large,
       'xl': Zeta.of(context).spacing.xl,
-      '2xl': Zeta.of(context).spacing.xl_2,
-      '3xl': Zeta.of(context).spacing.xl_3,
-      '4xl': Zeta.of(context).spacing.xl_4,
-      '5xl': Zeta.of(context).spacing.xl_5,
-      '6xl': Zeta.of(context).spacing.xl_6,
-      '7xl': Zeta.of(context).spacing.xl_7,
-      '8xl': Zeta.of(context).spacing.xl_8,
-      '9xl': Zeta.of(context).spacing.xl_9,
-      '10xl': Zeta.of(context).spacing.xl_10,
-      '11xl': Zeta.of(context).spacing.xl_11,
+      'xl_2': Zeta.of(context).spacing.xl_2,
+      'xl_3': Zeta.of(context).spacing.xl_3,
+      'xl_4': Zeta.of(context).spacing.xl_4,
+      'xl_5': Zeta.of(context).spacing.xl_5,
+      'xl_6': Zeta.of(context).spacing.xl_6,
+      'xl_7': Zeta.of(context).spacing.xl_7,
+      'xl_8': Zeta.of(context).spacing.xl_8,
+      'xl_9': Zeta.of(context).spacing.xl_9,
+      'xl_10': Zeta.of(context).spacing.xl_10,
+      'xl_11': Zeta.of(context).spacing.xl_11,
     };
     Map<String, double> baseSpacings = {
-      'x1': Zeta.of(context).spacing.primitives.x1,
-      'x2': Zeta.of(context).spacing.primitives.x2,
-      'x3': Zeta.of(context).spacing.primitives.x3,
-      'x4': Zeta.of(context).spacing.primitives.x4,
-      'x5': Zeta.of(context).spacing.primitives.x5,
-      'x6': Zeta.of(context).spacing.primitives.x6,
-      'x7': Zeta.of(context).spacing.primitives.x7,
-      'x8': Zeta.of(context).spacing.primitives.x8,
-      'x9': Zeta.of(context).spacing.primitives.x9,
-      'x10': Zeta.of(context).spacing.primitives.x10,
-      'x11': Zeta.of(context).spacing.primitives.x11,
-      'x12': Zeta.of(context).spacing.primitives.x12,
-      'x13': Zeta.of(context).spacing.primitives.x13,
-      'x14': Zeta.of(context).spacing.primitives.x14,
-      'x15': Zeta.of(context).spacing.primitives.x15,
+      'primitives.x1': Zeta.of(context).spacing.primitives.x1,
+      'primitives.x2': Zeta.of(context).spacing.primitives.x2,
+      'primitives.x3': Zeta.of(context).spacing.primitives.x3,
+      'primitives.x4': Zeta.of(context).spacing.primitives.x4,
+      'primitives.x5': Zeta.of(context).spacing.primitives.x5,
+      'primitives.x6': Zeta.of(context).spacing.primitives.x6,
+      'primitives.x7': Zeta.of(context).spacing.primitives.x7,
+      'primitives.x8': Zeta.of(context).spacing.primitives.x8,
+      'primitives.x9': Zeta.of(context).spacing.primitives.x9,
+      'primitives.x10': Zeta.of(context).spacing.primitives.x10,
+      'primitives.x11': Zeta.of(context).spacing.primitives.x11,
+      'primitives.x12': Zeta.of(context).spacing.primitives.x12,
+      'primitives.x13': Zeta.of(context).spacing.primitives.x13,
+      'primitives.x14': Zeta.of(context).spacing.primitives.x14,
+      'primitives.x15': Zeta.of(context).spacing.primitives.x15,
     };
 
     return ExampleScaffold(
@@ -55,12 +55,12 @@ class SpacingExample extends StatelessWidget {
             children: [
               Column(
                 crossAxisAlignment: CrossAxisAlignment.start,
-                children: baseSpacings.entries.map((obj) => _SpacingDemo(obj)).toList(),
+                children: semanticSpacings.entries.map((obj) => _SpacingDemo(obj)).toList(),
               ),
               Column(
                 crossAxisAlignment: CrossAxisAlignment.start,
-                children: semanticSpacings.entries.map((obj) => _SpacingDemo(obj)).toList(),
-              )
+                children: baseSpacings.entries.map((obj) => _SpacingDemo(obj)).toList(),
+              ),
             ],
           ),
         ),

example/widgetbook/pages/assets/icon_widgetbook.dart

@@ -51,7 +51,7 @@ Widget iconsUseCase(BuildContext context) {
                             nameArr,
                             textAlign: TextAlign.center,
                             maxLines: 2,
-                          )
+                          ),
                         ],
                       ),
                     ),

example/widgetbook/pages/introduction.dart

@@ -32,7 +32,7 @@ class _IntroductionWidgetbookState extends State<IntroductionWidgetbook> {
     return LayoutBuilder(builder: (context, constraints) {
       final bool largeScreen = constraints.maxWidth > 480;
       return Scaffold(
-        backgroundColor: colors.black,
+        backgroundColor: Colors.black,
         body: SingleChildScrollView(
           child: Padding(
             padding: EdgeInsets.symmetric(

lib/src/components/avatars/avatar.dart

@@ -326,7 +326,7 @@ extension on ZetaAvatarSize {
       case ZetaAvatarSize.xs:
       case ZetaAvatarSize.xxs:
       case ZetaAvatarSize.xxxs:
-        return ZetaBorders.borderWidth;
+        return ZetaBorders.medium;
     }
   }
 

lib/src/components/badges/indicator.dart

@@ -113,7 +113,7 @@ class ZetaIndicator extends ZetaStatelessWidget {
         height: sizePixels + Zeta.of(context).spacing.minimum,
         decoration: BoxDecoration(
           border: Border.all(
-            width: ZetaBorders.borderWidth,
+            width: ZetaBorders.medium,
             color: Zeta.of(context).colors.borderSubtle,
           ),
           color: (inverse ? foregroundColor : Colors.transparent),

lib/src/components/banner/banner.dart

@@ -1,5 +1,3 @@
-import 'dart:io';
-
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
@@ -65,7 +63,7 @@ class ZetaBanner extends MaterialBanner {
             builder: (context) {
               final backgroundColor = _backgroundColorFromType(context, type);
               final foregroundColor = backgroundColor.onColor;
-              if (!kIsWeb && Platform.isAndroid && context.mounted) {
+              if (!kIsWeb && PlatformIs.android && context.mounted) {
                 // ignore: invalid_use_of_visible_for_testing_member
                 final statusBarColor = SystemChrome.latestStyle?.statusBarColor;
                 if (statusBarColor != backgroundColor) {

lib/src/components/breadcrumbs/breadcrumbs.dart

@@ -321,7 +321,7 @@ class _BreadCrumbsTruncatedState extends State<_BreadCrumbsTruncated> {
                 side: WidgetStateProperty.resolveWith((states) {
                   if (states.contains(WidgetState.focused)) {
                     return BorderSide(
-                      width: ZetaBorders.borderWidth,
+                      width: ZetaBorders.medium,
                       color: colors.primary.shade100,
                     );
                   }

lib/src/components/button_group/button_group.dart

@@ -238,7 +238,7 @@ class _ZetaGroupButtonState extends State<ZetaGroupButton> {
     bool finalButton,
   ) {
     if (_controller.value.contains(WidgetState.focused)) {
-      return BorderSide(color: colors.blue.shade50, width: ZetaBorders.borderWidth);
+      return BorderSide(color: colors.blue.shade50, width: ZetaBorders.medium);
     }
     if (_controller.value.contains(WidgetState.disabled)) {
       return BorderSide(color: colors.cool.shade40);

lib/src/components/buttons/button_style.dart

@@ -137,7 +137,7 @@ ButtonStyle buttonStyle(
       }
       // TODO(UX-1134): This removes a defualt border when focused, rather than adding a second border when focused.
       if (states.contains(WidgetState.focused)) {
-        return BorderSide(color: colors.blue, width: ZetaBorders.borderWidth);
+        return BorderSide(color: colors.blue, width: ZetaBorders.medium);
       }
       if (type.border) {
         return BorderSide(

lib/src/components/chat_item/chat_item.dart

@@ -1,5 +1,4 @@
 // ignore_for_file: deprecated_member_use_from_same_package
-
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_slidable/flutter_slidable.dart';
@@ -134,22 +133,16 @@ class ZetaChatItem extends ZetaStatelessWidget {
 
     // coverage:ignore-start
     if (onMenuMoreTap != null) {
-      actions.add(
-        ZetaSlidableAction(onPressed: onMenuMoreTap, color: colors.purple, icon: ZetaIcons.more_vertical),
-      );
+      actions.add(ZetaSlidableAction.menuMore(onPressed: onMenuMoreTap));
     }
     if (onCallTap != null) {
-      actions.add(
-        ZetaSlidableAction(onPressed: onCallTap, color: colors.green, icon: ZetaIcons.phone),
-      );
+      actions.add(ZetaSlidableAction.call(onPressed: onCallTap));
     }
     if (onPttTap != null) {
-      actions.add(
-        ZetaSlidableAction(onPressed: onPttTap, color: colors.blue, icon: ZetaIcons.ptt),
-      );
+      actions.add(ZetaSlidableAction.ptt(onPressed: onPttTap));
     }
     if (onDeleteTap != null) {
-      actions.add(ZetaSlidableAction(onPressed: onDeleteTap, color: colors.red, icon: ZetaIcons.delete));
+      actions.add(ZetaSlidableAction.delete(onPressed: onDeleteTap));
     }
     // coverage:ignore-end
 

lib/src/components/chips/chip.dart

@@ -225,7 +225,7 @@ class _ZetaChipState extends State<ZetaChip> {
                 BorderSide(
                   color: _controller.value.contains(WidgetState.focused) ? colors.blue.shade50 : colors.borderDefault,
                   width: _controller.value.contains(WidgetState.focused)
-                      ? ZetaBorders.borderWidth
+                      ? ZetaBorders.medium
                       : !selected
                           ? 1
                           : 0,

lib/src/components/dial_pad/dial_pad.dart

@@ -198,7 +198,7 @@ class ZetaDialPadButton extends StatelessWidget {
         decoration: ShapeDecoration(
           shape: const CircleBorder(),
           color: colors.warm.shade10,
-          shadows: [BoxShadow(color: colors.black.withOpacity(0.15), blurRadius: 4, offset: const Offset(0, 2))],
+          shadows: [BoxShadow(color: Colors.black.withOpacity(0.15), blurRadius: 4, offset: const Offset(0, 2))],
         ),
         child: Material(
           color: Colors.transparent,

lib/src/components/fabs/fab.dart

@@ -137,7 +137,7 @@ class _ZetaFABState extends State<ZetaFAB> {
           (Set<WidgetState> states) {
             if (states.contains(WidgetState.focused)) {
               // TODO(UX-1134): This removes a defualt border when focused, rather than adding a second border when focused.
-              return BorderSide(color: Zeta.of(context).colors.blue.shade50, width: ZetaBorders.borderWidth);
+              return BorderSide(color: Zeta.of(context).colors.blue.shade50, width: ZetaBorders.medium);
             }
             return null;
           },

lib/src/components/global_header/global_header.dart

@@ -175,7 +175,7 @@ class _GlobalHeaderState extends State<ZetaGlobalHeader> {
             setState(() {
               _selectedIndex = index;
             });
-            child.handlePress!.call();
+            child.handlePress?.call();
           },
         ),
       );

lib/src/components/list_item/notification_list_item.dart

@@ -202,13 +202,8 @@ class ZetaNotificationBadge extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colors = Zeta.of(context).colors;
     return avatar != null
-        ? avatar!.copyWith(
-            size: ZetaAvatarSize.m,
-            lowerBadge: ZetaAvatarBadge.icon(icon: ZetaIcons.check_mark, color: colors.green),
-            backgroundColor: colors.purple.shade80,
-          )
+        ? avatar!.copyWith(size: ZetaAvatarSize.m)
         : icon != null
             ? ZetaIcon(
                 icon,