fix: set navigation item highlight shape to rectangle

test: edited test to pass after merge
ZebraDevs · Nov 13, 2024 · a1e3d67 · a1e3d67
1 parent 7bcad7c
commit a1e3d67
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/src/components/navigation bar/navigation_bar.dart b/lib/src/components/navigation bar/navigation_bar.dart
@@ -265,6 +265,7 @@ class NavigationItem extends ZetaStatelessWidget {
         borderRadius: context.rounded ? Zeta.of(context).radius.rounded : Zeta.of(context).radius.none,
         onTap: onTap,
         hoverColor: colors.surfaceHover,
+        highlightShape: BoxShape.rectangle,
         child: Semantics(
           button: true,
           excludeSemantics: true,

diff --git a/test/src/components/navigation_bar/navigation_bar_test.dart b/test/src/components/navigation_bar/navigation_bar_test.dart
@@ -370,9 +370,10 @@ void main() {
 
       await tester.pumpAndSettle();
 
-      final inkwell = tester.widget<InkWell>(find.descendant(of: itemFinder, matching: find.byType(InkWell)).first);
+      final inkResponse =
+          tester.widget<InkResponse>(find.descendant(of: itemFinder, matching: find.byType(InkResponse)).first);
 
-      expect(inkwell.hoverColor, Zeta.of(context).colors.surfaceHover);
+      expect(inkResponse.hoverColor, Zeta.of(context).colors.surfaceHover);
     });
   });