added fall back to post failure comment

ZebraDevs · Dec 4, 2024 · aa3dceb · aa3dceb
1 parent cfb5243
commit aa3dceb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -120,7 +120,7 @@ jobs:
               });
             }
       - name: Post failure comment
-        if: failure()
+        if: always()
         uses: actions/github-script@v6
         with:
           script: |
@@ -136,10 +136,13 @@ jobs:
               { name: 'Update changes in GitHub repository', conclusion: '${{ steps.update-changes-in-github-repository.outcome }}' }
             ].filter(step => step.conclusion === 'failure');
             const failedStepsDetails = failedSteps.map(step => `- ${step.name}: ${step.conclusion}`).join('\n');
-            const commentBody = `
+            const commentBody = failedSteps.length > 0 ? `
               ## Code Quality Checks Failed
               The following checks failed:
               ${failedStepsDetails}
+            `; : `
+              ## Code Quality Checks Failed
+              No checks failed.
             `;
             const { data: comments } = await github.rest.issues.listComments({
               issue_number: context.issue.number,

diff --git a/src/components/fab/fab.ts b/src/components/fab/fab.ts
@@ -56,8 +56,7 @@ export class ZetaFab extends Flavored(BaseButton) {
   @property({ type: String, reflect: true }) size: "small" | "large" = "small";
 
   private getLabel() {
-    // return this.label ? html`<div class="label">${this.label}</div>` : nothing;
-    return nothing;
+    return this.label ? html`<div class="label">${this.label}</div>` : nothing;
   }
   protected render() {
     return html`