feat: improving PR experience with comments #57
pull-request.yml
on: pull_request
Check the code quality
1m 52s
Deploy preview version of the storybook on firebase
0s
Annotations
3 errors and 1 warning
Check the code quality
Failed ESLint: Error: The process '/opt/hostedtoolcache/node/18.20.5/x64/bin/npm' failed with exit code 1
|
Check the code quality
Failed Lit Analyzer: Error: The process '/opt/hostedtoolcache/node/18.20.5/x64/bin/npm' failed with exit code 1
|
Check the code quality
> @zebra-fed/[email protected] test
> web-test-runner "src/test/**/*.test.ts" --node-resolve --coverage
Chromium: |█▎ | 0/46 test files | 0 passed, 0 failed
Running tests...
Running 46 test files...
�[2K�[1A�[2K�[G3:09:54 PM [vite] (client) ✨ new dependencies optimized: @open-wc/testing, lit, lit/decorators.js, lit/directives/if-defined.js, lit/directives/style-map.js
�[2K�[1A�[2K�[G3:09:55 PM [vite] (client) ✨ new dependencies optimized: @web/test-runner-commands, @zebra-fed/zeta-icons
3:09:55 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[G3:09:57 PM [vite] (client) ✨ new dependencies optimized: lit/directives/live.js
3:09:57 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/checkbox/checkbox.test.ts:
🚧 Browser logs:
Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
�[2K�[1A�[2K�[Gsrc/test/dropdown/dropdown-menu-button.test.ts:
🚧 Browser logs:
Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
Element zeta-radio-button scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
�[2K�[1A�[2K�[G3:09:58 PM [vite] (client) ✨ new dependencies optimized: @lit/localize
3:09:58 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/fab/fab.test.ts:
❌ zeta-fab > Content Tests > renders a button with a label
AssertionError: expected null to exist
at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=Quay--bXgIIHXXM9MQTlt:35:61)
❌ zeta-fab > Content Tests > renders an extended fab
AssertionError: expected null to exist
at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=Quay--bXgIIHXXM9MQTlt:54:34)
❌ zeta-fab > Content Tests > renders a default fab
AssertionError: expected null to exist
at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=Quay--bXgIIHXXM9MQTlt:63:30)
�[2K�[1A�[2K�[G3:09:59 PM [vite] (client) ✨ new dependencies optimized: lit/directives/unsafe-svg.js
3:09:59 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/navigation-drawer-footer/navigation-drawer-footer.test.ts:
🚧 Browser logs:
Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
�[2K�[1A�[2K�[Gsrc/test/navigation
|
Check the code quality
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|