feat: improving PR experience with comments #51
pull-request.yml
on: pull_request
Check the code quality
2m 15s
Deploy preview version of the storybook on firebase
0s
Annotations
3 errors and 1 warning
Check the code quality
> @zebra-fed/[email protected] lint:lit-analyzer
> lit-analyzer --quiet
Analyzing 288 files...
./src/components/fab/fab.ts
This tag isn't closed.
60: <button ?disabled=${this.disa
no-unclosed-tag
✖ 1 problem in 1 file (1 error, 0 warnings)
|
Check the code quality
Failed ESLint: true
|
Check the code quality
> @zebra-fed/[email protected] test
> web-test-runner "src/test/**/*.test.ts" --node-resolve --coverage
Chromium: |█▎ | 0/46 test files | 0 passed, 0 failed
Running tests...
Running 46 test files...
�[2K�[1A�[2K�[G2:00:14 PM [vite] (client) ✨ new dependencies optimized: @open-wc/testing, lit, lit/decorators.js, lit/directives/if-defined.js, lit/directives/style-map.js
�[2K�[1A�[2K�[G2:00:15 PM [vite] (client) ✨ new dependencies optimized: @web/test-runner-commands, @zebra-fed/zeta-icons
2:00:15 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[G2:00:17 PM [vite] (client) ✨ new dependencies optimized: lit/directives/live.js
2:00:17 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/checkbox/checkbox.test.ts:
🚧 Browser logs:
Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
�[2K�[1A�[2K�[Gsrc/test/dropdown/dropdown-menu-button.test.ts:
🚧 Browser logs:
Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
Element zeta-radio-button scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
�[2K�[1A�[2K�[G2:00:18 PM [vite] (client) ✨ new dependencies optimized: @lit/localize
2:00:18 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/fab/fab.test.ts:
❌ zeta-fab > Accessibility Tests > meets accessability requirements
Error: Accessibility Violations
---
Rule: color-contrast
Impact: serious
Elements must meet minimum color contrast ratio thresholds (https://dequeuniversity.com/rules/axe/4.10/color-contrast?application=axeAPI)
Issue target: zeta-fab,zeta-icon
Context: <zeta-icon><slot></slot></zeta-icon>
Fix any of the following:
Element has insufficient color contrast of 4.21 (foreground color: #f3f6fa, background color: #0073e6, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1
---
at processResults (node_modules/chai-a11y-axe/src/accessible.js:87:14)
at node_modules/chai-a11y-axe/src/accessible.js:123:6
at async n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=KwFKnLJPRzNGyABmmt10_:28:6)
❌ zeta-fab > Content Tests > renders a button with a label
AssertionError: expected null to exist
at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=KwFKnLJPRzNGyABmmt10_:35:61)
❌ zeta-fab > Content Tests > renders an extended fab
AssertionError: expected null to exist
at n.<anonymous>
|
Check the code quality
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|