feat(UX-1314): Created comment component #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikecoomber
commented
Nov 21, 2024
mikecoomber
commented
- Created comment component (https://www.figma.com/design/xY8ZaqWVuHMVUilDa5Tr9S/Workcloud-Sync%3A-To-Dos?node-id=11072-122133&node-type=frame&t=CqUFN13ghfqj5stK-0)
- Added file size to the attachment model
- Added elevation prop to the SlideableListTile
- Added semantic label to the slideable action and made label nullable while asserting that at least one had to be defined.
PR Checks complete
Created with Flutter code quality action |
thelukewalton
approved these changes
Nov 21, 2024
| final radius = Zeta.of(context).radius; | ||
|
|
||
| return Material( | ||
| child: InkWell( |
There was a problem hiding this comment.
I guess the design is not clear but i think some padding around the ink well splash would be better
| if (customThumbnail != null) | ||
| SizedBox( | ||
| width: 44, | ||
| height: 44, |
There was a problem hiding this comment.
why are custom thumbnails bigger than icons below?
This was referenced Nov 21, 2024
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.