Comment component fixes (#46)

fix: onDelete now gets invoked correctly for ZdsComment fix: Voice notes can now be disabled without the assertion failing
ZebraDevs · Nov 29, 2024 · 5bf1345 · 5bf1345
1 parent 8c85877
commit 5bf1345
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/example/lib/pages/components/comment.dart b/example/lib/pages/components/comment.dart
@@ -23,9 +23,13 @@ class _CommentDemoState extends State<CommentDemo> {
             author: 'John Doe',
             downloadCallback: () {},
             comment: 'This is a comment',
-            onReply: () {},
+            onReply: () {
+              print('reply');
+            },
             replySemanticLabel: 'Reply to comment',
-            onDelete: () {},
+            onDelete: () {
+              print('delete');
+            },
             deleteSemanticLabel: 'Delete',
             timeStamp: '09:30 AM',
             attachment: ZdsChatAttachment(

diff --git a/lib/src/components/molecules/comment.dart b/lib/src/components/molecules/comment.dart
@@ -112,7 +112,7 @@ class ZdsComment extends StatelessWidget {
                     ZdsSlidableAction(
                       icon: ZetaIcons.delete,
                       semanticLabel: deleteSemanticLabel,
-                      onPressed: (_) {},
+                      onPressed: (_) => onDelete!(),
                       backgroundColor: colors.surfaceNegativeSubtle,
                       foregroundColor: colors.error,
                     ),

diff --git a/lib/src/components/organisms/chat/message_input.dart b/lib/src/components/organisms/chat/message_input.dart
@@ -29,7 +29,7 @@ class ZdsMessageInput extends StatefulWidget {
     this.allowVoiceNotes = false,
     super.key,
   }) : assert(
-          allowVoiceNotes && voiceNoteFileName != null,
+          (allowVoiceNotes && voiceNoteFileName != null) || !allowVoiceNotes,
           'A value for voiceNoteFileName must be provided if allowVoiceNotes is enabled',
         );