Refactor test suite iteration to use for-of loop and improve test cas…

…e failure detection
ZebraDevs · Dec 23, 2024 · b6f9c83 · b6f9c83
1 parent 0960def
commit b6f9c83
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 18 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/scripts/testing.ts b/src/scripts/testing.ts
@@ -63,18 +63,18 @@ export const testing = async (
       "<table><tr><th>File</th><th>Test Name</th><th>Line</th><th>Type</th><th>Message</th></tr>";
 
     const testSuites = jsonResults["elements"][0]["elements"];
-    for (let i = 0; i < testSuites.length; i++) {
-      const testSuite = testSuites[i];
-      console.log(testSuite);
-      const testCases = testSuite["elements"].filter(
-        (element: any) => element.name === "testcase",
-      );
-      for (let j = 0; j < testCases.length; j++) {
-        const testCase = testCases[j];
+    for (const testSuite of testSuites) {
+      const testCases =
+        testSuite["elements"]?.filter(
+          (element: any) => element.name === "testcase",
+        ) ?? [];
+
+      for (const testCase of testCases) {
         const testCaseName = testCase["attributes"]["name"];
-        const testCaseFailure = testCase.filter(
-          (element: any) => element["elements"][0].name === "failure",
+        const testCaseFailure = testCase["elements"]?.find(
+          (element: any) => element.name === "failure",
         );
+
         if (testCaseFailure) {
           const file = testCase["attributes"]["file"];
           const line = testCase["attributes"]["line"];