refactor: enhance checkModifiedFiles to return modified status and st…

…reamline updateChanges logic

src/main.ts

@@ -192,25 +192,27 @@ export async function run(): Promise<void> {
       ? await commandComment({ label: "TSDoc", command: "npm run docs" })
       : undefined;
 
-    const checkModifiedFilesStr: StepResponse | undefined =
+    const [checkModifiedFilesStr, modified]: [StepResponse, boolean] =
       await checkModifiedFiles({
         label: "Check for modified files",
-        command:
-          'echo "modified=$(if [ -n "$(git status --porcelain)" ]; then echo "true"; else echo "false"; fi)" >> $GITHUB_ENV',
+        command: "git status --porcelain",
+        // 'echo "modified=$(if [ -n "$(git status --porcelain)" ]; then echo "true"; else echo "false"; fi)" >> $GITHUB_ENV',
       });
 
     // TODO: THIS DIDN't fail
-    const updateChangesStr: StepResponse | undefined = await updateChanges({
-      label: "Update changes in GitHub repository",
-      command: "",
-      commandList: [
-        'git config --global user.name "github-actions"',
-        'git config --global user.email "[email protected]"',
-        "git add -A",
-        'git commit -m "[automated commit] lint format and import sort"',
-        "git push",
-      ],
-    });
+    const updateChangesStr: StepResponse | undefined = modified
+      ? await updateChanges({
+          label: "Update changes in GitHub repository",
+          command: "",
+          commandList: [
+            'git config --global user.name "github-actions"',
+            'git config --global user.email "[email protected]"',
+            "git add -A",
+            'git commit -m "[automated commit] lint format and import sort"',
+            "git push",
+          ],
+        })
+      : undefined;
 
     // runCoverage
     // const coverageStr: StepResponse | undefined = runCoverage

src/scripts/post.ts

@@ -3,19 +3,25 @@ import { buildComment, Command, runBashCommand, StepResponse } from "src/main";
 
 export const checkModifiedFiles = async (
   command: Command,
-): Promise<StepResponse> => {
+): Promise<[StepResponse, boolean]> => {
+  let filesModified = false;
   const result = await runBashCommand(command.command)
     .then(async (str) => {
       const response = { output: "", error: false };
-      return await buildComment(response, str, command.label);
+      if (str.trim() !== "") {
+        filesModified = true;
+        return await buildComment(response, str, command.label);
+      } else {
+        return await buildComment(response, str, command.label);
+      }
     })
     .catch(async (error) => {
       setFailed(`Failed to check for modified files: ${error as string}`);
       const response = { output: "", error: true };
       return await buildComment(response, error.message, command.label);
     });
 
-  return result;
+  return [result, filesModified];
 };
 
 export const updateChanges = async (