Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from boost mutex to standard mutex locks in fetch_teleop #79

Open
cjds opened this issue Jul 12, 2018 · 2 comments
Open

Change from boost mutex to standard mutex locks in fetch_teleop #79

cjds opened this issue Jul 12, 2018 · 2 comments
Assignees
@cjds
Labels
enhancement
Milestone
18.04 & Melodic

Comments

@cjds
Copy link
Contributor

cjds commented Jul 12, 2018

Because locks are standard now?

https://github.com/fetchrobotics/fetch_ros/blob/melodic-devel/fetch_teleop/src/joystick_teleop.cpp#L153

https://en.cppreference.com/w/cpp/thread/mutex
@cjds cjds self-assigned this Jul 12, 2018
@moriarty
Copy link
Contributor

👍

@moriarty
Copy link
Contributor

Can also change boost::shared_ptr to std::shared_ptr.

@moriarty moriarty added this to the 18.04 & Melodic milestone Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjds cjds

Labels
enhancement
Projects
None yet
Milestone
18.04 & Melodic
Development

No branches or pull requests
2 participants
@moriarty @cjds