Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(mahalend): Add Mahalend app #2940

Closed
wants to merge 3 commits into from

Conversation

comandar21
Copy link
Contributor

@comandar21 comandar21 commented Sep 12, 2023

Description

We are adding Mahalend integration to zappe

Checklist

  • [ x] I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

@comandar21 comandar21 changed the title feat(mahalend):Add Mahalend app feat(mahalend): Add Mahalend app Sep 12, 2023
@comandar21 comandar21 changed the title feat(mahalend): Add Mahalend app feat(mahalend): Add mahalend app Sep 12, 2023
@comandar21 comandar21 changed the title feat(mahalend): Add mahalend app feat(add-mahalend): Add mahalend app Sep 12, 2023
@comandar21 comandar21 changed the title feat(add-mahalend): Add mahalend app feat(mahalend): Add mahalend app Sep 12, 2023
@comandar21 comandar21 changed the title feat(mahalend): Add mahalend app feat(mahalend): Mahalend app Added Sep 12, 2023
@comandar21 comandar21 changed the title feat(mahalend): Mahalend app Added feat(mahalend): Add Mahalend app Sep 12, 2023
@wpoulin
Copy link
Contributor

wpoulin commented Sep 12, 2023

You don't need to duplicate the aave-v2 abstract classes in /common

You can extend AaveV2LendingTokenFetcher and you won't need to copy pasta a bunch of files and abis.
Have a look how it's been done with aave-v2 src/apps/aave-v2/ethereum

@wpoulin
Copy link
Contributor

wpoulin commented Nov 2, 2023

Can't merge it just yet because of This branch is out-of-date with the base branch

Make sure to add remote upstream, pull master and push origin. Then the warning will disapear
@comandar21

@wpoulin
Copy link
Contributor

wpoulin commented Jan 24, 2024

We are closing Zapper Studio to new contributions. Instead, we'll be rolling out codeless app balance integrations, where folks can create integrations on Zapper's frontend (with no coding experience needed)

Here's the official announcement. I'll add mahalend to my todo since codeless app integrations aren't open to public just yet and I'll close this PR
Thanks for your contribution !

@wpoulin wpoulin closed this Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants