fix(meta-street): Linting (#2967)

Zapper-fi · Oct 11, 2023 · 2e9c881 · 2e9c881
1 parent b2ce320
commit 2e9c881
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/src/apps/meta-street/ethereum/meta-street.lending-v2-legacy.contract-position-fetcher.ts b/src/apps/meta-street/ethereum/meta-street.lending-v2-legacy.contract-position-fetcher.ts
@@ -5,7 +5,7 @@ import { gql } from 'graphql-request';
 import { APP_TOOLKIT, IAppToolkit } from '~app-toolkit/app-toolkit.interface';
 import { PositionTemplate } from '~app-toolkit/decorators/position-template.decorator';
 import { gqlFetch } from '~app-toolkit/helpers/the-graph.helper';
-
+import { MetaType } from '~position/position.interface';
 import { ContractPositionTemplatePositionFetcher } from '~position/template/contract-position.template.position-fetcher';
 import {
   GetDefinitionsParams,
@@ -15,7 +15,6 @@ import {
   GetTokenBalancesParams,
   GetDataPropsParams,
 } from '~position/template/contract-position.template.types';
-import { MetaType } from '~position/position.interface';
 
 import { MetaStreetContractFactory, PoolV2Legacy } from '../contracts';
 
@@ -93,17 +92,17 @@ export type Redemption = {
 
 @PositionTemplate()
 export class EthereumMetaStreetLendingV2LegacyContractPositionFetcher extends ContractPositionTemplatePositionFetcher<PoolV2Legacy> {
-  groupLabel: string = 'Lending V2 Legacy';
+  groupLabel = 'Lending V2 Legacy';
 
   constructor(
     @Inject(APP_TOOLKIT) protected readonly appToolkit: IAppToolkit,
-    @Inject(MetaStreetContractFactory) protected readonly MetaStreetContractFactory: MetaStreetContractFactory,
+    @Inject(MetaStreetContractFactory) protected readonly contractFactory: MetaStreetContractFactory,
   ) {
     super(appToolkit);
   }
 
   getContract(_address: string): PoolV2Legacy {
-    return this.MetaStreetContractFactory.poolV2Legacy({ address: _address, network: this.network });
+    return this.contractFactory.poolV2Legacy({ address: _address, network: this.network });
   }
 
   async getDefinitions(_params: GetDefinitionsParams): Promise<ContractPositionDefinition[]> {
@@ -192,7 +191,7 @@ export class EthereumMetaStreetLendingV2LegacyContractPositionFetcher extends Co
     );
 
     /* Get account's withdrawal logs and compute withdrawn amount and burned shares */
-    let firstDepositBlockNumber: number = depositLogs.length > 0 ? depositLogs[0].blockNumber : START_BLOCK_NUMBER;
+    const firstDepositBlockNumber: number = depositLogs.length > 0 ? depositLogs[0].blockNumber : START_BLOCK_NUMBER;
     const withdrawLogs = await contract.queryFilter(contract.filters.Withdrawn(address, tick), firstDepositBlockNumber);
     const withdrawn: Withdrawn = withdrawLogs.reduce(
       (withdrawn: Withdrawn, l) => {

diff --git a/src/apps/meta-street/ethereum/meta-street.lending-v2.contract-position-fetcher.ts b/src/apps/meta-street/ethereum/meta-street.lending-v2.contract-position-fetcher.ts
@@ -5,7 +5,7 @@ import { gql } from 'graphql-request';
 import { APP_TOOLKIT, IAppToolkit } from '~app-toolkit/app-toolkit.interface';
 import { PositionTemplate } from '~app-toolkit/decorators/position-template.decorator';
 import { gqlFetch } from '~app-toolkit/helpers/the-graph.helper';
-
+import { MetaType } from '~position/position.interface';
 import { ContractPositionTemplatePositionFetcher } from '~position/template/contract-position.template.position-fetcher';
 import {
   GetDefinitionsParams,
@@ -15,7 +15,6 @@ import {
   GetTokenBalancesParams,
   GetDataPropsParams,
 } from '~position/template/contract-position.template.types';
-import { MetaType } from '~position/position.interface';
 
 import { MetaStreetContractFactory, PoolV2 } from '../contracts';
 
@@ -93,17 +92,17 @@ export type Redemption = {
 
 @PositionTemplate()
 export class EthereumMetaStreetLendingV2ContractPositionFetcher extends ContractPositionTemplatePositionFetcher<PoolV2> {
-  groupLabel: string = 'Lending V2';
+  groupLabel = 'Lending V2';
 
   constructor(
     @Inject(APP_TOOLKIT) protected readonly appToolkit: IAppToolkit,
-    @Inject(MetaStreetContractFactory) protected readonly MetaStreetContractFactory: MetaStreetContractFactory,
+    @Inject(MetaStreetContractFactory) protected readonly contractFactory: MetaStreetContractFactory,
   ) {
     super(appToolkit);
   }
 
   getContract(_address: string): PoolV2 {
-    return this.MetaStreetContractFactory.poolV2({ address: _address, network: this.network });
+    return this.contractFactory.poolV2({ address: _address, network: this.network });
   }
 
   async getDefinitions(_params: GetDefinitionsParams): Promise<ContractPositionDefinition[]> {
@@ -191,7 +190,7 @@ export class EthereumMetaStreetLendingV2ContractPositionFetcher extends Contract
     );
 
     /* Get account's withdrawal logs and compute withdrawn amount and burned shares */
-    let firstDepositBlockNumber: number = depositLogs.length > 0 ? depositLogs[0].blockNumber : START_BLOCK_NUMBER;
+    const firstDepositBlockNumber: number = depositLogs.length > 0 ? depositLogs[0].blockNumber : START_BLOCK_NUMBER;
     const withdrawLogs = await contract.queryFilter(contract.filters.Withdrawn(address, tick), firstDepositBlockNumber);
     const withdrawn: Withdrawn = withdrawLogs.reduce(
       (withdrawn: Withdrawn, l) => {

diff --git a/src/apps/meta-street/meta-street.module.ts b/src/apps/meta-street/meta-street.module.ts
@@ -3,8 +3,8 @@ import { Module } from '@nestjs/common';
 import { AbstractApp } from '~app/app.dynamic-module';
 
 import { MetaStreetContractFactory } from './contracts';
-import { EthereumMetaStreetLendingV2ContractPositionFetcher } from './ethereum/meta-street.lending-v2.contract-position-fetcher';
 import { EthereumMetaStreetLendingV2LegacyContractPositionFetcher } from './ethereum/meta-street.lending-v2-legacy.contract-position-fetcher';
+import { EthereumMetaStreetLendingV2ContractPositionFetcher } from './ethereum/meta-street.lending-v2.contract-position-fetcher';
 
 @Module({
   providers: [