Upgrade mongodb to 6.3.0 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markedg
commented
Mar 4, 2024
| const finalize = async(err, d) => { | ||
| if (err) { | ||
| const finalize = async (err, d) => { | ||
| if (err !== null && err !== undefined) { |
There was a problem hiding this comment.
If the err was an empty string, a null value was cached. This happened to us when using got and http2, which does not define a statusMessage and was therefore passing in an empty err string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the node mongo db driver compatibility to 6.3.0 while maintaining backwards compatibility for mongo 4 and 5.
Includes a small change to the stampede
finalizecode to prevent null values from being saved.